-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add check on zk parser #28
feat: add check on zk parser #28
Conversation
Visit the preview URL for this PR (updated for commit a76a332): https://zksync-docs-staging-5eb09--pr28-itsacoyote-devrl-487-wuthvex2.web.app (expires Tue, 07 May 2024 14:23:22 GMT) π₯ via Firebase Hosting GitHub Action π Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11 |
Orrrr do we just want to throw a straight up Error and break the server if an unparsed tag is found? |
@itsacoyote I think this fine, it will be identified in the CI anyway right? So we will still be aware of the need to fix. |
Actually I don't think it would be identified by the CI? |
It will not, this is part of the dev process which is why I was worried about throwing an Error in it. While you're developing locally and it throws, it throws a bit of a wrench in the local server and makes it a pain to start back up. I'll have to look a bit further into the lifecycle of the build process and see if I can find a way to throw only during a build command. |
7793901
to
3c7e236
Compare
@dutterbutter I've got an error that I can throw and make it fatal but it still doesn't cleanly exit the process with a proper error code. The failure is because the rest of the build process gets borked which isn't really the best way. I'd have to dig into this further but don't want to waste more time on it right now, what are your thoughts on how we should handle this for now? An error does occur in the |
Agreed, let's not spend too much time on this right now. Let's sit on this and think through later, perhaps during offsite. Feel free to keep as is or move to draft state. |
5dcc71b
to
a76a332
Compare
What π»
Why β
Evidence π·
NOTE
This does not stop a build process from happening. The parser runs on dev and if an error is Thrown it causes all sorts of hiccups on the local server to restart smoothly. For now this is just a console log for the developer to notice. May sit on this and think of a way to throw an error only on build later on.