Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed commits comment #39

Merged
merged 6 commits into from
May 9, 2024
Merged

Signed commits comment #39

merged 6 commits into from
May 9, 2024

Conversation

uF4No
Copy link
Contributor

@uF4No uF4No commented Apr 29, 2024

What 💻

Why ✋

  • Adds info about signed commits

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@uF4No uF4No requested a review from a team as a code owner April 29, 2024 15:38
Copy link

github-actions bot commented Apr 29, 2024

Visit the preview URL for this PR (updated for commit 5e66098):

https://zksync-docs-staging-5eb09--pr39-feat-signed-commits-zy898sgm.web.app

(expires Thu, 16 May 2024 18:53:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

account](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account),
and [telling git about your signing
key](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we adjust this so that each link is in a numbered line item? This way it's easier to see there are three steps.

@itsacoyote itsacoyote merged commit 7fe1c58 into staging May 9, 2024
7 checks passed
@itsacoyote itsacoyote deleted the feat/signed-commits branch May 9, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signed commits requirement
2 participants