chore: add sdk docs to nav #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit acd4fed): https://zksync-docs-staging-5eb09--pr55-db-add-sdk-docs-7zdax19t.web.app (expires Thu, 16 May 2024 18:46:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11 |
itsacoyote
reviewed
May 9, 2024
| { | ||
| label: 'SDK Docs', | ||
| to: 'https://staging-docs.zksync.io/sdk', | ||
| }, |
There was a problem hiding this comment.
Is this just to get the links up there temporarily for testing? Otherwise we want to set this up for linking to the proper endpoint per environment.
There was a problem hiding this comment.
Actually, I think we can set this to '/sdk' and the cloudflare rules should still be able to handle redirecting to the SDK endpoint?
itsacoyote
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: zksync-sdk/sdk-docs#7
What 💻
Why ✋
Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended