Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Itsacoyote quick fixes #83

Merged
merged 6 commits into from
May 23, 2024
Merged

Itsacoyote quick fixes #83

merged 6 commits into from
May 23, 2024

Conversation

itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented May 22, 2024 •
edited
Loading

Resolves DEVRL-690, DEVRL-691, DEVRL-627, DEVRL-649, DEVRL-692

List of changes

  • added links to breadcrumbs
    • added redirects for certain paths that don't have an index page
  • fixed links that were improperly formatted for Nuxt Content
  • adjusted some buttons that were too large
  • update Dev Updates card on landing page to point to zksyncDevs twitter account
  • remove the version update link in the hero section of the landing page
  • moved cards on the Build index page down to the bottom of the page

@itsacoyote itsacoyote requested a review from a team as a code owner May 22, 2024 19:04
@itsacoyote itsacoyote requested a review from uF4No May 22, 2024 19:05
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit aaafad4):

https://zksync-docs-staging-5eb09--pr83-itsacoyote-quick-fix-rpjokzkb.web.app

(expires Wed, 29 May 2024 19:13:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

cpb8010
cpb8010 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested some of the links and they worked, having an automated dead link checker might be nice.
The other changes seem small

components/layout/DocsBase.vue
to,
}));
// removes the link to the current page, unnecessary
delete crumbs[crumbs.length - 1].to;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is what breaks all the existing links by removing the last navigation link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking something?

@itsacoyote
Copy link
Contributor Author

I tested some of the links and they worked, having an automated dead link checker might be nice. The other changes seem small

Nuxt Content does a pretty good job of checking internal links for anything that's broken. I think we've got another link checker elsewhere in the git workflow that also checks links in another way.

@itsacoyote itsacoyote merged commit 606e617 into staging May 23, 2024
8 checks passed
@itsacoyote itsacoyote deleted the itsacoyote-quick-fixes branch May 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpb8010 cpb8010 cpb8010 approved these changes

@uF4No uF4No Awaiting requested review from uF4No

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsacoyote @cpb8010