Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated verify commands #88

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: updated verify commands #88

merged 1 commit into from
May 28, 2024

Conversation

amelnytskyi
Copy link
Contributor

@amelnytskyi amelnytskyi commented May 28, 2024

What πŸ’»

  • updated verify commands for npm and pnpm (UUPS) to align with Beacon and Transparent proxy tutorials - current npm run hardhat verify <PROXY-ADDRESS> fails

Why βœ‹

  • Reason why first thing was added to PR
  • Reason why second thing was added to PR
  • Reason why third thing was added to PR

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended
image

@amelnytskyi amelnytskyi requested a review from a team as a code owner May 28, 2024 14:01
@amelnytskyi amelnytskyi self-assigned this May 28, 2024
@itsacoyote
Copy link
Contributor

@amelnytskyi you'll need to merge or rebase from staging to get the checks passing. There are updates that should help fix the checks from breaking.

Copy link

Visit the preview URL for this PR (updated for commit 4b88af3):

https://zksync-docs-staging-5eb09--pr88-qa-fix-verify-comman-n5kzhd6y.web.app

(expires Tue, 04 Jun 2024 16:11:41 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

@amelnytskyi
Copy link
Contributor Author

@itsacoyote @uF4No since all checks are now passed - PR is ready for review

@itsacoyote itsacoyote merged commit f5d4c8f into staging May 28, 2024
8 checks passed
@itsacoyote itsacoyote deleted the qa-fix-verify-commands branch May 28, 2024 16:19
@amelnytskyi
Copy link
Contributor Author

Thanks @itsacoyote !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants