Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(en): Make batch status updater work with pruned data #863

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Jan 12, 2024

What ❔

Modifies batch status updater so that it works with pruned node data during snapshot recovery.

Why ❔

Part of preparations of EN code to support snapshot recovery.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@slowli slowli marked this pull request as ready for review January 12, 2024 12:32
@slowli slowli requested review from popzxc and tomg10 January 12, 2024 13:55
Copy link
Contributor

@tomg10 tomg10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments, I will look at the rest of the PR (i.e. mostly tests) later today

tomg10
tomg10 previously approved these changes Jan 16, 2024
popzxc
popzxc previously approved these changes Jan 16, 2024
@slowli slowli dismissed stale reviews from popzxc and tomg10 via 688fedf January 16, 2024 13:07
@slowli slowli added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2024
@slowli slowli added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 3a07890 Jan 16, 2024
27 checks passed
@slowli slowli deleted the aov-pla-707-snapshot-recovery-make-batch-status-updater-work-with-pruned branch January 16, 2024 16:05
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[19.2.0](core-v19.1.1...core-v19.2.0)
(2024-01-17)


### Features

* adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck`
ci usage ([#868](#868))
([d64f584](d64f584))
* **contract-verifier:** Support zkVM solc contract verification
([#854](#854))
([1ed5a95](1ed5a95))
* **en:** Make batch status updater work with pruned data
([#863](#863))
([3a07890](3a07890))
* rewritten gossip sync to be async from block processing
([#711](#711))
([3af4644](3af4644))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Deniallugo pushed a commit that referenced this pull request Jan 21, 2024
🤖 I have created a release *beep* *boop*
---

[19.2.0](core-v19.1.1...core-v19.2.0)
(2024-01-17)

* adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck`
ci usage ([#868](#868))
([d64f584](d64f584))
* **contract-verifier:** Support zkVM solc contract verification
([#854](#854))
([1ed5a95](1ed5a95))
* **en:** Make batch status updater work with pruned data
([#863](#863))
([3a07890](3a07890))
* rewritten gossip sync to be async from block processing
([#711](#711))
([3af4644](3af4644))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Deniallugo pushed a commit that referenced this pull request Jan 21, 2024
🤖 I have created a release *beep* *boop*
---

[19.2.0](core-v19.1.1...core-v19.2.0)
(2024-01-17)

* adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck`
ci usage ([#868](#868))
([d64f584](d64f584))
* **contract-verifier:** Support zkVM solc contract verification
([#854](#854))
([1ed5a95](1ed5a95))
* **en:** Make batch status updater work with pruned data
([#863](#863))
([3a07890](3a07890))
* rewritten gossip sync to be async from block processing
([#711](#711))
([3af4644](3af4644))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants