-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(en): Make batch status updater work with pruned data #863
Merged
slowli
merged 12 commits into
main
from
aov-pla-707-snapshot-recovery-make-batch-status-updater-work-with-pruned
Jan 16, 2024
Merged
feat(en): Make batch status updater work with pruned data #863
slowli
merged 12 commits into
main
from
aov-pla-707-snapshot-recovery-make-batch-status-updater-work-with-pruned
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomg10
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments, I will look at the rest of the PR (i.e. mostly tests) later today
core/lib/zksync_core/src/sync_layer/batch_status_updater/mod.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/sync_layer/batch_status_updater/mod.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/sync_layer/batch_status_updater/mod.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/sync_layer/batch_status_updater/mod.rs
Outdated
Show resolved
Hide resolved
tomg10
previously approved these changes
Jan 16, 2024
popzxc
previously approved these changes
Jan 16, 2024
popzxc
approved these changes
Jan 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 16, 2024
slowli
deleted the
aov-pla-707-snapshot-recovery-make-batch-status-updater-work-with-pruned
branch
January 16, 2024 16:05
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
🤖 I have created a release *beep* *boop* --- ## [19.2.0](core-v19.1.1...core-v19.2.0) (2024-01-17) ### Features * adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck` ci usage ([#868](#868)) ([d64f584](d64f584)) * **contract-verifier:** Support zkVM solc contract verification ([#854](#854)) ([1ed5a95](1ed5a95)) * **en:** Make batch status updater work with pruned data ([#863](#863)) ([3a07890](3a07890)) * rewritten gossip sync to be async from block processing ([#711](#711)) ([3af4644](3af4644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Deniallugo
pushed a commit
that referenced
this pull request
Jan 21, 2024
🤖 I have created a release *beep* *boop* --- [19.2.0](core-v19.1.1...core-v19.2.0) (2024-01-17) * adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck` ci usage ([#868](#868)) ([d64f584](d64f584)) * **contract-verifier:** Support zkVM solc contract verification ([#854](#854)) ([1ed5a95](1ed5a95)) * **en:** Make batch status updater work with pruned data ([#863](#863)) ([3a07890](3a07890)) * rewritten gossip sync to be async from block processing ([#711](#711)) ([3af4644](3af4644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Deniallugo
pushed a commit
that referenced
this pull request
Jan 21, 2024
🤖 I have created a release *beep* *boop* --- [19.2.0](core-v19.1.1...core-v19.2.0) (2024-01-17) * adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck` ci usage ([#868](#868)) ([d64f584](d64f584)) * **contract-verifier:** Support zkVM solc contract verification ([#854](#854)) ([1ed5a95](1ed5a95)) * **en:** Make batch status updater work with pruned data ([#863](#863)) ([3a07890](3a07890)) * rewritten gossip sync to be async from block processing ([#711](#711)) ([3af4644](3af4644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Modifies batch status updater so that it works with pruned node data during snapshot recovery.
Why ❔
Part of preparations of EN code to support snapshot recovery.
Checklist
zk fmt
andzk lint
.zk spellcheck
.