feat: adds zk linkcheck to zk tool and updates zk env for zk linkcheck ci usage
#868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de markdown-link-checker npm package
5 tasks
montekki
reviewed
Jan 14, 2024
Deniallugo
previously approved these changes
Jan 14, 2024
montekki
approved these changes
Jan 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
🤖 I have created a release *beep* *boop* --- ## [19.2.0](core-v19.1.1...core-v19.2.0) (2024-01-17) ### Features * adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck` ci usage ([#868](#868)) ([d64f584](d64f584)) * **contract-verifier:** Support zkVM solc contract verification ([#854](#854)) ([1ed5a95](1ed5a95)) * **en:** Make batch status updater work with pruned data ([#863](#863)) ([3a07890](3a07890)) * rewritten gossip sync to be async from block processing ([#711](#711)) ([3af4644](3af4644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
Related PRs: - #868 - #870 ## What ❔ - Addresses broken links in the repo <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ - Should not have dead links in the repo - Addressing issues with links prior to `zk linkcheck` usage in ci <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`.
Deniallugo
pushed a commit
that referenced
this pull request
Jan 21, 2024
🤖 I have created a release *beep* *boop* --- [19.2.0](core-v19.1.1...core-v19.2.0) (2024-01-17) * adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck` ci usage ([#868](#868)) ([d64f584](d64f584)) * **contract-verifier:** Support zkVM solc contract verification ([#854](#854)) ([1ed5a95](1ed5a95)) * **en:** Make batch status updater work with pruned data ([#863](#863)) ([3a07890](3a07890)) * rewritten gossip sync to be async from block processing ([#711](#711)) ([3af4644](3af4644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Deniallugo
pushed a commit
that referenced
this pull request
Jan 21, 2024
🤖 I have created a release *beep* *boop* --- [19.2.0](core-v19.1.1...core-v19.2.0) (2024-01-17) * adds `zk linkcheck` to zk tool and updates zk env for `zk linkcheck` ci usage ([#868](#868)) ([d64f584](d64f584)) * **contract-verifier:** Support zkVM solc contract verification ([#854](#854)) ([1ed5a95](1ed5a95)) * **en:** Make batch status updater work with pruned data ([#863](#863)) ([3a07890](3a07890)) * rewritten gossip sync to be async from block processing ([#711](#711)) ([3af4644](3af4644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
zk linkcheckto ci to prevent dead links #870What ❔
zk linkcheckto zk toolzk linkcheckin zk envzk linkcheckdocsspellcheckdir to be generalchecks-configdir to include spellcheck and link configuration fileszk spellcheckexit codeWhy ❔
zk linkcheckwill ensure no dead links exist in repo and prevent unnecessary PRszk spellcheckzk linkcheckusageChecklist
zk fmtandzk lint.zk spellcheck.