Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: zksync-ethers 5.8.0-beta.5 #1763

Merged
merged 638 commits into from
May 16, 2024
Merged

chore: zksync-ethers 5.8.0-beta.5 #1763

merged 638 commits into from
May 16, 2024

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Apr 22, 2024 •
edited
Loading

What ❔

Start using the https://github.com/zksync-sdk/zksync-ethers/releases/tag/v5.8.0-beta.5 release from the SDK, instead of depending a GitHub commit.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

ly0va and others added 30 commits March 15, 2024 13:31
@ly0va
Commitment utils fix
1e22b58
@juan518munoz
fix init and zk test i server
599d318
@benceharomi
Merge pull request #1440 from lambdaclass/kl-factory
35df259 
fix(kl-factory): fix init and zk test i server
@fkrause98
Merge branch 'kl-factory' into base-token-addr-endpoint
cb6b373
@fkrause98
feat: Handle Web3Error::NotImplemented after merge
28f6523
@fkrause98
fix: update protobuf config
9cd48b7
@juan518munoz
zk fmt
5680df8
@juan518munoz
Merge remote-tracking branch 'matter-labs/kl-factory' into gas-oracle
47c444f
update package.json
df9664c
@juan518munoz
initial commit
3baab56
@juan518munoz
zk fmt
b6baace
@juan518munoz
fix test
aa868fb
@juan518munoz
rename native token to base token
b520744
@juan518munoz
fix env load
29289c9
@ly0va
Merge pull request #1479 from lambdaclass/kl-factory-integration-test…
53aa529 
…s/custom-accounts

fix(kl-factory/integration-tests): custom accounts
add gas oracle documentation
7c8ec45
fmt
2a7761d
@fkrause98
Merge branch 'kl-factory' into gas-oracle
55ae89f
@ly0va
Merge pull request #1481 from lambdaclass/kl-factory-fix-contracts-tests
911e1de 
fix(kl-factory): fix contracts tests
@ly0va
Update yarn.lock
cef5baa
@ly0va
Switch contracts to without-1.5.0 branch
8166d7f
@ly0va
Bump contracts again
3c284b3
@ly0va
Upgrade test works
4735e34
@ly0va
Minor integration tests fixes
b2bb23c
@ly0va
zk fmt
4b58ffa
@kelemeno
add hyperchain upgrade script
e16c3e7
@kelemeno
changing back bridge names in server for backwards
c684bf4 
compatibility
@kelemeno
bridge names in server for backwards comp
d4b3842 
bump contracts
@kelemeno
generating upgrade data
6e4e4c9
@kelemeno
latest to genesis protocol version
f5e39dc
@mm-zk
Copy link
Collaborator

mm-zk commented Apr 25, 2024

LGTM - but please revert the change in contracts (the code should work without it, right?)

@benceharomi benceharomi marked this pull request as draft May 8, 2024 12:05
benceharomi and others added 14 commits May 8, 2024 13:05
@benceharomi
Merge branch 'main' into bh-evm-575-start-using-beta-release-from-the…
150ec60 
…-sdk
@benceharomi
fix: zksync-ethers dependency commit changed
308fc02
@benceharomi
fix(yarn.lock): zksync-ethers version in contracts
2085884
@benceharomi
Merge branch 'main' into bh-evm-575-start-using-beta-release-from-the…
b3e7883 
…-sdk
@benceharomi
Merge branch 'main' into bh-evm-575-start-using-beta-release-from-the…
4b7e074 
…-sdk
@benceharomi
chore(upgrade.test.ts): zksync-web3 dependency removed
4315b54
@benceharomi
chore(snapshot-recovery-test): zksync-web3 dependency removed
d99086c
@benceharomi
chore(revert-test): zksync-web3 dependency removed
b1a7900
@benceharomi
chore(protocol-upgrade): zksync-web3 dependency removed
bff80a6
@benceharomi
yarn.lock
9c26e7f
@benceharomi
chore(tests): zkweb3 imports renamed to zksync
daf8577
@benceharomi
Merge branch 'main' into bh-evm-575-start-using-beta-release-from-the…
6d4d627 
…-sdk
@benceharomi
Merge remote-tracking branch 'origin/main' into bh-evm-575-start-usin…
809e12c 
…g-beta-release-from-the-sdk
@benceharomi
Merge branch 'main' into bh-evm-575-start-using-beta-release-from-the…
cdcfb11 
…-sdk
@benceharomi benceharomi marked this pull request as ready for review May 15, 2024 10:43
@github-actions GitHub Actions
Copy link
Contributor

No performance difference detected (anymore)

mm-zk
mm-zk reviewed May 16, 2024
View reviewed changes
yarn.lock Show resolved Hide resolved
mm-zk
mm-zk reviewed May 16, 2024
View reviewed changes
yarn.lock Show resolved Hide resolved
@benceharomi benceharomi added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 0cdd12b May 16, 2024
44 checks passed
@benceharomi benceharomi deleted the bh-evm-575-start-using-beta-release-from-the-sdk branch May 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-zk mm-zk mm-zk approved these changes

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.