Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Prover CLI): delete cmd #1802

Merged
merged 45 commits into from
May 14, 2024
Merged

feat(Prover CLI): delete cmd #1802

merged 45 commits into from
May 14, 2024

Conversation

ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Apr 25, 2024

What ❔

Adds command delete to the Prover CLI. This command is used for:

  • Deleting the entire prover DB.
  • Deleting all the data of a given batch.
  • Deleting all the data for all the failed jobs of a given batch.

Why ❔

A prover operator may want to delete data related to some batch or batches, and even all the DB.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@ilitteri ilitteri marked this pull request as ready for review April 30, 2024 18:33
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left a bunch of nits.

EmilLuta
EmilLuta previously approved these changes May 3, 2024
@EmilLuta EmilLuta added this pull request to the merge queue May 3, 2024
@ilitteri ilitteri requested a review from EmilLuta May 6, 2024 16:44
ColoCarletti
ColoCarletti previously approved these changes May 7, 2024
Copy link
Contributor

@ColoCarletti ColoCarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Artemka374 Artemka374 merged commit 6e4a92e into main May 14, 2024
26 checks passed
@Artemka374 Artemka374 deleted the prover_cli_delete_cmd branch May 14, 2024 11:55
RomanBrodetski pushed a commit that referenced this pull request May 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.2.0](prover-v14.1.1...prover-v14.2.0)
(2024-05-17)


### Features

* Added support for making EN a (non-leader) consensus validator
(BFT-426)
([#1905](#1905))
([9973629](9973629))
* **configs:** Extract secrets to an additional config
([#1956](#1956))
([bab4d65](bab4d65))
* **eth-client:** Generalize RPC client
([#1898](#1898))
([a4e099f](a4e099f))
* **Prover CLI:** `delete` cmd
([#1802](#1802))
([6e4a92e](6e4a92e))
* **Prover CLI:** `requeue` cmd
([#1719](#1719))
([f722df7](f722df7))
* **Prover CLI:** `status batch --verbose`
([#1899](#1899))
([cf80184](cf80184))
* **state-keeper:** Parallel l2 block sealing
([#1801](#1801))
([9b06dd8](9b06dd8))
* tee_verifier_input_producer
([#1860](#1860))
([fea7f16](fea7f16))


### Bug Fixes

* **Prover CLI:** `status batch` bugs
([#1865](#1865))
([09682f2](09682f2))
* **prover:** Bump Cargo.lock and update VKs
([#1959](#1959))
([367baad](367baad))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants