-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Prover CLI): delete
cmd
#1802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilLuta
reviewed
May 3, 2024
EmilLuta
reviewed
May 3, 2024
EmilLuta
reviewed
May 3, 2024
EmilLuta
reviewed
May 3, 2024
EmilLuta
reviewed
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Left a bunch of nits.
EmilLuta
previously approved these changes
May 3, 2024
ColoCarletti
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat(Prover CLI): `restart` cmd
…-era into prover_cli_delete_cmd
Artemka374
approved these changes
May 14, 2024
RomanBrodetski
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- ## [14.2.0](prover-v14.1.1...prover-v14.2.0) (2024-05-17) ### Features * Added support for making EN a (non-leader) consensus validator (BFT-426) ([#1905](#1905)) ([9973629](9973629)) * **configs:** Extract secrets to an additional config ([#1956](#1956)) ([bab4d65](bab4d65)) * **eth-client:** Generalize RPC client ([#1898](#1898)) ([a4e099f](a4e099f)) * **Prover CLI:** `delete` cmd ([#1802](#1802)) ([6e4a92e](6e4a92e)) * **Prover CLI:** `requeue` cmd ([#1719](#1719)) ([f722df7](f722df7)) * **Prover CLI:** `status batch --verbose` ([#1899](#1899)) ([cf80184](cf80184)) * **state-keeper:** Parallel l2 block sealing ([#1801](#1801)) ([9b06dd8](9b06dd8)) * tee_verifier_input_producer ([#1860](#1860)) ([fea7f16](fea7f16)) ### Bug Fixes * **Prover CLI:** `status batch` bugs ([#1865](#1865)) ([09682f2](09682f2)) * **prover:** Bump Cargo.lock and update VKs ([#1959](#1959)) ([367baad](367baad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds command
delete
to the Prover CLI. This command is used for:Why ❔
A prover operator may want to delete data related to some batch or batches, and even all the DB.
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.