feat(vm-runner): implement output handler for VM runner #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
reviewed
May 6, 2024
|
Still working on the documentation but functionally I think the PR is ready for a review |
perekopskiy
previously approved these changes
May 13, 2024
slowli
reviewed
May 15, 2024
perekopskiy
approved these changes
May 16, 2024
RomanBrodetski
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- ## [24.3.0](core-v24.2.0...core-v24.3.0) (2024-05-16) ### Features * Added support for making EN a (non-leader) consensus validator (BFT-426) ([#1905](#1905)) ([9973629](9973629)) * **configs:** Extract secrets to an additional config ([#1956](#1956)) ([bab4d65](bab4d65)) * **en:** Fetch L1 batch root hashes from main node ([#1923](#1923)) ([72a3571](72a3571)) * **eth-client:** Generalize RPC client ([#1898](#1898)) ([a4e099f](a4e099f)) * **Prover CLI:** `requeue` cmd ([#1719](#1719)) ([f722df7](f722df7)) * **Prover CLI:** `status batch --verbose` ([#1899](#1899)) ([cf80184](cf80184)) * **pruning:** Vacuum freeze started daily ([#1929](#1929)) ([5c85e9f](5c85e9f)) * Remove metrics crate ([#1902](#1902)) ([5f7bda7](5f7bda7)) * **state-keeper:** Parallel l2 block sealing ([#1801](#1801)) ([9b06dd8](9b06dd8)) * tee_verifier_input_producer ([#1860](#1860)) ([fea7f16](fea7f16)) * **vm-runner:** implement output handler for VM runner ([#1856](#1856)) ([1e4aeb5](1e4aeb5)) ### Bug Fixes * **basic_types:** bincode deserialization for `web3::Bytes` ([#1928](#1928)) ([406ec8c](406ec8c)) * **config:** Fix data-handler-config ([#1919](#1919)) ([b6bb041](b6bb041)) * **en:** Delete old txs by (init_addr, nonce) ([#1942](#1942)) ([fa5f4a7](fa5f4a7)) * **en:** Fix reorg detector logic for dealing with last L1 batch ([#1906](#1906)) ([3af5f5b](3af5f5b)) * parentHash in websocket blocks subscription is shown as 0x0 ([#1946](#1946)) ([fc2efad](fc2efad)) * **Prover CLI:** `status batch` bugs ([#1865](#1865)) ([09682f2](09682f2)) * **utils:** bincode ser-/deserialization for `BytesToHexSerde` ([#1947](#1947)) ([a75b917](a75b917)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR creates a new abstraction
OutputHandlerFactorythat can orchestrate output handlers in a non-trivial manner. Specifically, for the purposes of VM runner we create an implementationConcurrentOutputHandlerFactorythat can produce delegated output handlers that internally use another output handler (i.e. delegatee is specific to the VM runner implementation). The main benefit of this implementation is thathandle_l1_batchis non-blocking and finishes almost immediately. The actual work is spawned as a future and is then handled asynchronously enabling us to create many output handlers in parallel.Why ❔
One of the components for the upcoming VM runner
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.