feat(Prover CLI): Configuration (with flag) #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilLuta
reviewed
May 7, 2024
EmilLuta
previously approved these changes
May 8, 2024
This reverts commit a5be588.
auto-merge was automatically disabled
May 8, 2024 16:33
Merge queue setting changed
EmilLuta
approved these changes
May 8, 2024
RomanBrodetski
pushed a commit
that referenced
this pull request
May 11, 2024
🤖 I have created a release *beep* *boop* --- ## [14.1.0](prover-v14.0.0...prover-v14.1.0) (2024-05-11) ### Features * **en:** Brush up EN observability config ([#1897](#1897)) ([086f768](086f768)) * Extract several crates from zksync_core ([#1859](#1859)) ([7dcf796](7dcf796)) * **Prover CLI:** Configuration (with flag) ([#1861](#1861)) ([620c880](620c880)) * **Prover CLI:** Initial Docs ([#1862](#1862)) ([8b094aa](8b094aa)) * **Prover CLI:** status l1 command ([#1706](#1706)) ([8ddd039](8ddd039)) * prover components versioning ([#1660](#1660)) ([29a4ffc](29a4ffc)) ### Bug Fixes * 1.5.0 + validium (contracts only) patches ([#1911](#1911)) ([bf439f4](bf439f4)) * Update prover cargo lock ([#1896](#1896)) ([2ca01f5](2ca01f5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds the possibility to configure the DB URL. For now, we use a flag
--db-urlfor passing it. If not passed it defaults topostgres://postgres:notsecurepassword@localhost/prover_local.In the future, we should handle this differently, with an independent command
configto set one or multiple configurations into a.pli-configfile.This also removes the need for the CLI to be run with
zk f.Why ❔
We need to offer the Prover CLI users to provide the DB URL to which they want to work. In addition, we want to get rid of the need for
zk fto run the app.Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.