Add a [de]serialization unit test for the Bytes
#1933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assume we only use serde_json... Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
5 tasks
popzxc
reviewed
May 15, 2024
|
|
||
| #[test] | ||
| fn test_bytes_serde() { | ||
| use bincode::{deserialize, serialize}; |
There was a problem hiding this comment.
Bikeshedding: probably using fully qualified paths here would be more expressive.
Comment on lines
+87
to
+88
| #[test] | ||
| fn test_bytes_serde() { |
There was a problem hiding this comment.
If we are to test differences between serializer, it might also make sense to add:
- Tests for human-readable (de)serialization, e.g.
serde_json(though I guess it's kinda covered by the test above). - Snapshot tests for bincode serialization (we don't want to accidentally break repr there)
haraldh
force-pushed
the
web3_bytes_serializer
branch
from
6a08706
to
d7d0ed4
Compare
|
added this to #1928 |
1 similar comment
|
added this to #1928 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.