Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prover): [WIP] add FFLONK support to compressor #2766

Open
wants to merge 84 commits into
base: main
Choose a base branch
from
Open

feat(prover): [WIP] add FFLONK support to compressor #2766

wants to merge 84 commits into from
+4,315 −532

Conversation

itegulov
Copy link
Contributor

@itegulov itegulov commented Aug 29, 2024 •
edited by Artemka374
Loading

What ❔

This PR as of commit d1178f7 should work as is and I suggest to whoever picks this work up to try and run this on a g2-16 machine on GCP to confirm that everything works as intended.

TODO:

  1. [BLOCKED] Test this PR e2e with contracts that are updated to support FFLONK (they were not available during my work but hopefully are by the time you are reading this). I expect there to be some friction in serialization format expected by EVM. I took code suggested by Sait but it is completely untested.
  2. Add workflow to generate VKs and setup keys for FFLONK compressor

Changes:

  • VK generation - with GPU and 4 threads takes ~20m

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Artemka374 Artemka374 changed the title feat(prover): switch compression to fflonk feat(prover): [WIP] add FFLONK support to compressor Nov 4, 2024
@Artemka374 Artemka374 marked this pull request as ready for review November 4, 2024 12:10
@Artemka374 Artemka374 requested a review from a team as a code owner November 5, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itegulov @Artemka374