Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prover): do not get max attempts from config #2862

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(prover): do not get max attempts from config #2862

merged 1 commit into from
Sep 16, 2024

Conversation

Deniallugo
Copy link
Contributor

@Deniallugo Deniallugo commented Sep 12, 2024 •
edited
Loading

What ❔

Do not use envs inside Prover Cli

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Deniallugo
fix(prover): do not get max attempts from config
4ee24f7 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo marked this pull request as ready for review September 12, 2024 14:40
@Deniallugo Deniallugo merged commit c9db10f into deniallugo-full-deprecate-zk Sep 16, 2024
30 checks passed
@Deniallugo Deniallugo deleted the deniallugo-fix-prover-tests branch September 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deniallugo @EmilLuta