Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: updated dependency for focalboard server #5009

Merged
merged 24 commits into from
Jun 7, 2024

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented May 30, 2024

Fixes: https://mattermost.atlassian.net/browse/MM-58301

This PR Includes:

Dependency Update:

  • Updated the Mattermost server dependency from github.com/mattermost/mattermost-server/v6/public to github.com/mattermost/mattermost/server/public.

Go Version Upgrade:

  • Bumped the Go version from 1.19 to 1.21.

GitHub Workflow Updates:

  • Updated Go dependencies in GitHub workflows.

Code Cleanup:

  • Removed unnecessary code files and their related implementations across Focalboard:
    • cloud.go: cloud limits are no longer applied as part of plugins, also removed the server-side code which was using cloud limits.
    • limit.go: Removed for the same reason as cloud.go.
    • insight.go: Removed as insights on boards are no longer supported.
    • statistics.go: Removed as statistics routes are no longer supported.

@marianunez marianunez self-requested a review May 30, 2024 14:07
@Rajat-Dabade Rajat-Dabade self-assigned this May 30, 2024
Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Rajat-Dabade! Let some comments below and there is still more limits and insights code we can delete.

mattermost-plugin/server/boards/boards_service_api.go Outdated Show resolved Hide resolved
mattermost-plugin/server/boards/boardsapp_test.go Outdated Show resolved Hide resolved
mattermost-plugin/server/boards/configuration.go Outdated Show resolved Hide resolved
mattermost-plugin/server/boards/configuration_test.go Outdated Show resolved Hide resolved
server/api/api.go Outdated Show resolved Hide resolved
server/app/blocks_test.go Outdated Show resolved Hide resolved
server/app/cloud.go Outdated Show resolved Hide resolved
server/model/board_insights.go Outdated Show resolved Hide resolved
webapp/src/components/viewHeader/viewHeader.tsx Outdated Show resolved Hide resolved
webapp/src/components/viewHeader/viewHeader.tsx Outdated Show resolved Hide resolved
@Rajat-Dabade Rajat-Dabade requested a review from marianunez June 3, 2024 11:41
Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @Rajat-Dabade

Left some minor comments but one thing we do want to double check is that some settings are coming through the clientConfig.FeatureFlags which we do want to keep. The only FeatureFlag we don't want to check any longer is the one where it determined if Boards was running as a product in the server or not (the old MPA model)

server/app/statistics.go Show resolved Hide resolved
server/services/store/sqlstore/data_migrations.go Outdated Show resolved Hide resolved
server/services/store/sqlstore/migrate.go Outdated Show resolved Hide resolved
webapp/src/components/cardDetail/cardDetail.tsx Outdated Show resolved Hide resolved
webapp/src/route.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside the minor revert of the boardsEditor setting, everything LGTM. Great work @Rajat-Dabade 🎉

@Rajat-Dabade
Copy link
Contributor Author

Reverted the changes for BoardEditor setting back. Thanks 🙌 @marianunez

@Rajat-Dabade Rajat-Dabade merged commit c8e729b into main Jun 7, 2024
18 checks passed
@Rajat-Dabade Rajat-Dabade deleted the dependency-update-server branch June 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants