-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: updated dependency for focalboard server #5009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Rajat-Dabade! Let some comments below and there is still more limits and insights code we can delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @Rajat-Dabade
Left some minor comments but one thing we do want to double check is that some settings are coming through the clientConfig.FeatureFlags
which we do want to keep. The only FeatureFlag we don't want to check any longer is the one where it determined if Boards was running as a product in the server or not (the old MPA model)
webapp/src/components/onboardingTour/tourTipRenderer/tourTipRenderer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside the minor revert of the boardsEditor setting, everything LGTM. Great work @Rajat-Dabade 🎉
Reverted the changes for BoardEditor setting back. Thanks 🙌 @marianunez |
Fixes: https://mattermost.atlassian.net/browse/MM-58301
This PR Includes:
Dependency Update:
github.com/mattermost/mattermost-server/v6/public
github.com/mattermost/mattermost/server/public
.Go Version Upgrade:
GitHub Workflow Updates:
Code Cleanup: