Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added links to docs, clarified field text #41

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Added links to docs, clarified field text #41

merged 5 commits into from
Jan 25, 2021

Conversation

aaronrothschild
Copy link
Contributor

Updated some field text, and added direct links to the configuration pages.

@aaronrothschild aaronrothschild added this to the v1.0.0 milestone Jan 25, 2021
@aaronrothschild aaronrothschild mentioned this pull request Jan 25, 2021
Closed
larkox
larkox approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of one small detail, LGTM.

plugin.json Outdated Show resolved Hide resolved
justinegeffen
justinegeffen approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Aaron, LGTM!

plugin.json Outdated Show resolved Hide resolved
plugin.json Outdated Show resolved Hide resolved
plugin.json Outdated Show resolved Hide resolved
@justinegeffen justinegeffen self-requested a review January 25, 2021 16:37
@justinegeffen justinegeffen added the 4: Reviews Complete All reviewers have approved the pull request label Jan 25, 2021
@justinegeffen justinegeffen merged commit 68cb2d6 into master Jan 25, 2021
@justinegeffen justinegeffen deleted the teams-docs branch January 25, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@justinegeffen justinegeffen justinegeffen approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrothschild @larkox @justinegeffen