Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-48541] Removing license restrictions #80

Merged
merged 3 commits into from
Nov 22, 2022
Merged

[MM-48541] Removing license restrictions #80

merged 3 commits into from
Nov 22, 2022

Conversation

javaguirre
Copy link
Contributor

@javaguirre javaguirre commented Oct 6, 2022 •
edited by hanzei
Loading

Summary

MS Teams integration can be used with any Mattermost license now, removing License restriction code.

Ticket Link

https://mattermost.atlassian.net/browse/MM-48541

javaguirre
javaguirre commented Oct 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@javaguirre javaguirre marked this pull request as ready for review October 6, 2022 15:29
hanzei
hanzei approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Oct 6, 2022
@hanzei hanzei added this to the v2.1.0 milestone Oct 6, 2022
@catalintomai
Copy link

@javaguirre , if there isn't one open, please open a Jira ticket to capture the same and link here. Might be needed for reporting in Product, other places. Thanks! cc: @asatkinson

@hanzei hanzei added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Oct 6, 2022
@DHaussermann
Copy link

@hanzei and @javaguirre I'll take a look. But I believe we also need a corresponding marketplace PR to include the plugin in the marketplace result set.

@javaguirre
Copy link
Contributor Author

Didn't know that, I'll check how that works, thank you! 👍

DHaussermann
DHaussermann approved these changes Oct 6, 2022
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Tested no license applied
  • Tested Starter, Professional and Enterprise
  • Tested On-Prem and Cloud
  • No issues Enabling the plugin in any cases.

LGTM!

@DHaussermann DHaussermann added 1: PM Review Requires review by a product manager QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Oct 6, 2022
asatkinson
asatkinson approved these changes Nov 21, 2022
View reviewed changes
Copy link

@asatkinson asatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket Link = https://mattermost.atlassian.net/browse/MM-48541?atlOrigin=eyJpIjoiZjgwZTI2OWU4OGNiNDY4ZjlmZWUxNWZkNTQzYjI1ZDQiLCJwIjoiaiJ9

@javaguirre javaguirre merged commit 927b17c into master Nov 22, 2022
@javaguirre javaguirre deleted the feature/remove-license-restrictions branch November 22, 2022 08:59
@hanzei hanzei changed the title Removing license restrictions [MM-48541] Removing license restrictions Nov 22, 2022
This was referenced Dec 1, 2022
Merged
Closed
@hanzei hanzei mentioned this pull request Dec 13, 2022
Merged
@Schleuse Schleuse mentioned this pull request Feb 3, 2023
Closed
@Schleuse Schleuse mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@hanzei hanzei hanzei approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

@asatkinson asatkinson asatkinson approved these changes

@catalintomai catalintomai Awaiting requested review from catalintomai

Assignees
No one assigned
Labels
1: PM Review Requires review by a product manager QA Review Done PR has been approved by QA
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@javaguirre @catalintomai @DHaussermann @larkox @hanzei @asatkinson