Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slash command autocomplete functionality #50

Closed
iomodo opened this issue May 28, 2020 · 5 comments · Fixed by #69
Closed

Add slash command autocomplete functionality #50

iomodo opened this issue May 28, 2020 · 5 comments · Fixed by #69
Assignees
@rahulchheda
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Milestone
v1.3.0

Comments

@iomodo
Copy link

iomodo commented May 28, 2020

From 5.24 MM server has a slash command autocomplete functionality feature. An API can be found here
To implement the feature add AutocompleteData struct to the Command when registering a slash command.

Similar PRs:
For Todo plugin mattermost-community/mattermost-plugin-todo#69
For Agenda plugin mattermost-community/mattermost-plugin-agenda#40
@iomodo iomodo added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Tech/Go Type/Enhancement New feature or improvement of existing feature labels May 28, 2020
@rahulchheda
Copy link

Would like to take this up @iomodo, seems like a fairly easy issue, can I get more context for this?

@iomodo
Copy link
Author

iomodo commented Jun 15, 2020

Hey @rahulchheda sure, the way to implement this one is to go through the ExecuteCommand method in the plugin and convert all commands/subcommands to the autocomplete. You can see in the similar PRs how exactly it is done. If you have any question do not hesitate to ping me on community.

@iomodo iomodo removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 15, 2020
@iomodo
Copy link
Author

iomodo commented Jul 2, 2020

Hey @rahulchheda, are you still working on this? Do you have any questions?

@rahulchheda
Copy link

Hey @iomodo , will attempt it over this weekend. Sorry for the delay.

@jfrerich jfrerich added this to the v1.3.0 milestone Jul 15, 2020
@jfrerich
Copy link
Contributor

Hi @rahulchheda! Do you have any updates on this issue? Do you have a PR you could publish as a draft and we could give you some early feedback?

@aaronrothschild aaronrothschild mentioned this issue Oct 6, 2020
Open
@pazdev pazdev mentioned this issue May 19, 2021
Merged
hanzei pushed a commit that referenced this issue May 29, 2021
@pazdev @pazalamd @mattermod
[GH-50] Added slash command autocomplete functionality (#69)
e59c942 
Co-authored-by: Parvez Alam <parvez.alam@demansol.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulchheda rahulchheda

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

[GH-50] Added slash command autocomplete functionality
4 participants
@jespino @iomodo @jfrerich @rahulchheda