Allow restricting welcomebot invitations to non-guest accounts

[jfrerich]

Hey team, is this a known behaviour: on a customer instance it seems the welcomebot is inviting guest accounts to channels and the guests can just join without be added manually?

Issue created from a Mattermost message by @flexo3001.

[maisnamrajusingh]

@jfrerich is this something I can help with ?

[maisnamrajusingh]

@jfrerich I tried to replicate the issue but couldn't replicate it. Would it be possible to get access to the config.json settings the user used for the welcomebot settings ?

[jfrerich]

@jfrerich attached a message from @aaronrothschild

Hmmm...that's an interesting situation. @dylan.haussermann do we test for this at all?

This seems like a good new issue: restrict welcomebot messages to "full" users and ignore "guest" users (add an option in config to observe this behavior optionally)

[jfrerich]

@jfrerich attached a message from @aaronrothschild

@jason.frerich or @shota.gvinepadze I suspect the plugin bot has permissions to add the user to any channel (and does so) - without taking into account they are a guest account.

[jfrerich]

@jfrerich attached a message from @aaronrothschild

cc @katie.wiersgalla Just a heads up about this edge case with regards to Guest accounts and welcomebot inviting the users to join a channel on the server (which they probably shouldn't be presented with). When they click the button, they get added to channels on the server. I suspect this is unexpected behavior. It's not "broken" per se - the plugin has the ability/permission to add users to any channel. We'll triage it as a bug/story, but it's not high priority because Welcomebot is not available to Cloud customers currently.

[jfrerich]

@jfrerich attached a message from @aaronrothschild

I agree there should be a configuration to disable/enable ignoring a guest user. For now, let's address the main issue of in a private MM instance, guests should not be invited to welcomebot rules. If it's an open instance, then users can receive welcomebot messages and get added to room. .

I could see this gettingmore complex (ie: For guests, show them THIS rule instead, etc.)....but let's start simple.

[jfrerich]

@jfrerich I tried to replicate the issue but couldn't replicate it. Would it be possible to get access to the config.json settings the user used for the welcomebot settings ?

@maisnamraju, are you having issues replicating the case where a guest account is getting invited via the welcomebot rules? I believe the ask for this particular ticket is to add the restriction that guest user accounts to not get invited. @aaronrothschild, is that correct?

[maisnamraju]

@jfrerich I tried to replicate the issue but couldn't replicate it. Would it be possible to get access to the config.json settings the user used for the welcomebot settings ?

@maisnamraju, are you having issues replicating the case where a guest account is getting invited via the welcomebot rules? I believe the ask for this particular ticket is to add the restriction that guest user accounts to not get invited. @aaronrothschild, is that correct?

Yes, I wanted to replicate this bug. Can you lay out the steps I can use to replicate this issue ?

[maisnamrajusingh]

@jfrerich sorry I haven't been checking up on this one, but could you show me how I could replicate this condition ?