Restrict channel invitations to non-guest accounts #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
approved these changes
Apr 6, 2022
jfrerich
approved these changes
Apr 13, 2022
Co-authored-by: Jason Frerich <jason.frerich@mattermost.com>
streamer45
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We hit an issue on our Community server where a guest was getting automatically added to channels they were not supposed to be in when joining a team.
PR adds an option to conditionally include guests when adding users to channels. I've kept it opt-in (default is false) as it seems to me like the more secure approach but feel free to let me know if you think it's better to have it opt-out (to retain the existing behaviour that is).
Fixes #63