Deprecated legacy config settings & telemetry #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iseconds & removed multiple deprecated settings from telemetry docs
|
Newest code from cwarnermm has been published to preview environment for Git SHA b8e82ef |
hanzei
requested changes
Apr 3, 2024
Comment on lines
+389
to
+394
| +-----------------------------------------------------------------+------------------------------------------------------------------------+ | ||
| | The maximum number of idle connections held open from one | - System Config path: N/A | | ||
| | server to all others in the cluster. | - ``config.json`` setting: ``".ClusterSettings.MaxIdleConns: 100,`` | | ||
| | | - Environment variable: ``MM_CLUSTERSETTINGS_MAXIDLECONNS`` | | ||
| | Numerical input. Default is **100**. | | | ||
| +-----------------------------------------------------------------+------------------------------------------------------------------------+ |
There was a problem hiding this comment.
The formatting is different to the other deprecated settings in the file. Is that intended?
There was a problem hiding this comment.
Quite a few of the deprecated config settings are in this format since they get copied over directly when deprecated.
There was a problem hiding this comment.
The only existing one I could find is Enable publicly-shared boards (https://github.com/mattermost/docs/blob/deprecate-legacy-configs/source/configure/deprecated-configuration-settings.rst#enable-publicly-shared-boards).
I'm 0/5 on what format to use. 1/5 that it looks a bit inconsistent to use different formats.
hanzei
approved these changes
Apr 4, 2024
Comment on lines
+389
to
+394
| +-----------------------------------------------------------------+------------------------------------------------------------------------+ | ||
| | The maximum number of idle connections held open from one | - System Config path: N/A | | ||
| | server to all others in the cluster. | - ``config.json`` setting: ``".ClusterSettings.MaxIdleConns: 100,`` | | ||
| | | - Environment variable: ``MM_CLUSTERSETTINGS_MAXIDLECONNS`` | | ||
| | Numerical input. Default is **100**. | | | ||
| +-----------------------------------------------------------------+------------------------------------------------------------------------+ |
There was a problem hiding this comment.
The only existing one I could find is Enable publicly-shared boards (https://github.com/mattermost/docs/blob/deprecate-legacy-configs/source/configure/deprecated-configuration-settings.rst#enable-publicly-shared-boards).
I'm 0/5 on what format to use. 1/5 that it looks a bit inconsistent to use different formats.
|
Agreed that the inconsistency isn't ideal; however, resources are limited and consistency on a deprecation page isn't a priority at this time. |
cwarnermm
added
3: Reviews Complete
Merged
amyblais
added a commit
that referenced
this pull request
Apr 16, 2024
* Update conf.py * Update download-latest-tarball.rst * Update download-latest-tarball.rst * Update download-latest-tarball.rst * Update download-latest-tarball.rst * Corrected config setting name for onboarding flow (#7006) * Added guidance for max image decoder concurrency (#7010) * Added guidance for max image decoder concurrency * Incorporated reviewer feedback * Added 2 new profiling reports: allocs & mutex (#7008) * Corrected default value for OutgoingIntegrationRequestsDefaultTimeout (#7013) * Reordered page & provided next steps to share packet (#7009) * Deprecated MaxIdleConns, MaxIdleConnsPerHost, and IdleConnTimeoutMilliseconds & removed multiple deprecated settings from telemetry docs (#7014) * Update download-latest-tarball.rst * Clarify consequences of EmailBatchingBufferSize & EmailBatchingInterval config settings (#7015) * Added links to technical GH repo docs re: rtcd (#7034) * Corrected inline LaTeX rendering in message text as disabled by default (#7036) * Added legacy redirects impacting top forum engagement topics (#7037) * Forum listening: Added archival/deletion context for default channels (#7038) * Added archival/deletion context for default channels * Corrected note syntax * Forum listening: Clarified status activity & added link to away configuration setting (#7039) * Clarified status activity & added link to away configuration setting * Rearranged order of 2 table bullets * Added theme-icon class to status images to support Dark Mode * Added config setting needed to create accounts for preview instances (#7041) * Fixed malformed syntax for per-channel notification preferences (#7042) * Clarified who can make new threads (#7043) * Clarified ServiceSettings for EnableTutorial & EnableOnboardingFlow (#7045) * Clarified conversion from private to public workflow (#7046) * Forum listening: Added uninstall FAQ when desktop app installed via snap on linux (#7040) * Added uninstall FAQ when desktop app installed via snap on linux * Shortened table width to fit on page without requiring horizontal scroll * Add 0.3 legal hold demo to the docs (#7044) * Add 0.3 demo to the docs * Added sneak peek video * Fixed broken ref link syntax * v9.7 changelog (#6985) * Update release-lifecycle.rst * Update open-source-components.rst * Update download-latest-tarball.rst * Update download-latest-tarball.rst * Update mattermost-changelog.md * Update mattermost-changelog.md * Update mattermost-changelog.md * Update mattermost-changelog.md * Update mattermost-changelog.md * Update mattermost-changelog.md * Update mattermost-changelog.md * Update mattermost-changelog.md * Add contributors * Update mattermost-changelog.md * Update source/deploy/mattermost-changelog.md Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update source/deploy/mattermost-changelog.md Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update source/deploy/mattermost-changelog.md Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update mattermost-changelog.md * Update mattermost-changelog.md --------- Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> --------- Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for: https://mattermost.atlassian.net/browse/MM-57106
Deprecated the following HA config settings: MaxIdleConns, MaxIdleConnsPerHost, and IdleConnTimeoutMill…iseconds. Also removed multiple deprecated settings from telemetry docs documented erroneously.