Update SqlSettings.MaxIdleConns default setting #7063
Conversation
|
Newest code from hanzei has been published to preview environment for Git SHA c8594b6 |
hanzei
added
2: Editor Review
|
@hanzei - Please update the default value in the table to match the search metadata. Thanks! |
|
@agnivade "Because it is completely manual and there's no sync with the code. I'd rather just have a link the the default config.json generated for any config setting." -- I agree. It would be ideal to find a way to generate config docs directly from code rather than maintain the docs manually. Lowers the potential for errors, and reduces manual effort each release. |
|
Newest code from cwarnermm has been published to preview environment for Git SHA fd85900 |
|
It is not impossible. For our load-test repo, we can auto-generate the default config from struct fields which can be easily exposed in the Go pkg documentation at https://pkg.go.dev/github.com/mattermost/mattermost/server/public@v0.1.0/model#Config. This is something @isacikgoz created. But we haven't ported it to the main MM repo yet. |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 2fa290a |
|
Newest code from hanzei has been published to preview environment for Git SHA 7086644 |
|
Newest code from hanzei has been published to preview environment for Git SHA e76ef22 |
|
@cwarnermm Good catch; I also updated the table. PTAL. |
cwarnermm
added
3: Reviews Complete
|
Newest code from cwarnermm has been published to preview environment for Git SHA db901f6 |
Summary
Per https://github.com/mattermost/mattermost/blob/98712737e600e8b11e7d72ea90faa266227aa855/server/public/model/config.go#L1236-L1238.
It seems like the default setting was always at 20, and the docs were always incorrect.
Ticket Link
None