Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop v5.10: Removed full screen mode on Linux #7514

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Desktop v5.10: Removed full screen mode on Linux #7514

merged 1 commit into from
Nov 7, 2024

Conversation

cwarnermm
Copy link
Member

Documentation for: mattermost/desktop#3151

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Oct 29, 2024
@cwarnermm cwarnermm added this to the v10.2.0 milestone Oct 29, 2024
@github-actions GitHub Actions
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 859340d

devinbinnie
devinbinnie approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought - we might want to explain why this is missing in the docs, but if you don't feel it's necessary we can leave it at this.

@cwarnermm
Copy link
Member Author

cwarnermm commented Oct 29, 2024 •
edited
Loading

@devinbinnie - I was thinking the same and that would fit well in our changelog notes. @amyblais - Are you open to drafting a changelog note that details why we're removing fullscreen mode for the Desktop App on Linux? Details about why are available in the Engineering PR.

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Oct 29, 2024
@amyblais
Copy link
Member

Are you open to drafting a changelog note that details why we're removing fullscreen mode for the Desktop App on Linux? Details about why are available in the Engineering PR.

The PR description is comprehensive, so I added a link to it in the changelog.

@cwarnermm cwarnermm merged commit 30876b0 into v10.2-documentation Nov 7, 2024
4 checks passed
@cwarnermm cwarnermm deleted the desktop-510-disable-fullscreen branch November 7, 2024 15:13
amyblais added a commit that referenced this pull request Nov 15, 2024
@amyblais @cwarnermm
@marianunez @wiggin77 @cpoile @mgdelacroix
V10.2 Docs (#7494)
555f7d3 
* Update conf.py

* Re-adding missing image

* Removed Cloud deploy badge (#7513)

* Removed full screen mode on Linux (#7514)

* Replaced Calls plugin prefs with general page (#7516)

* Updated End Call for All to server v10.2 (#7517)

* Updated list of exported data (#7518)

* Pinned icon hidden when no messages pinned in channel (#7519)

* Pinned icon hidden when no messages pinned in channel

* Update source/collaborate/save-pin-messages.rst

* Added release details for MobileExternalBrowser (#7520)

* Clarified AllowOtherServers functionality (#7556)

* Clarified that LDAP users can't be deactivated via MM (#7561)

* Added menu option to access logs (#7521)

* Added EnableAPIPostDeletion config setting & mmctl command (#7563)

* Added PG FAQs based on customer input (#7586)

* Added env var developer mode setting (#7515)

* Added env var developer mode setting

* Update source/configure/environment-configuration-settings.rst

* Update source/configure/environment-configuration-settings.rst

* Editing pass updates

* Added upgrade & maintenance guidance for plugins (#7554)

* Added upgrade & maintenance guidance for plugins

* Update source/integrate/github-interoperability.rst

Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>

* Update source/guides/integrate-and-extend.rst

* Incorporated reviewer feedback

---------

Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>

* Config in database corrections (#7559)

* Reordered process

* Elevated HA guidance

* Incorporated reviewer feedback

* Updated language & added docs link (#7582)

* Docs listening: Clarified the path config for the ES certificate (#7583)

* Clarified the path config for the ES certificate

* Update source/configure/environment-configuration-settings.rst

* Added mobile workflow (#7584)

* Added Playbooks FAQs based on customer feedback (#7585)

* Docs listening: Added custom emoji screenshot (#7587)

* Added custom emoji screenshot

* Update source/collaborate/react-with-emojis-gifs.rst

* v10.2 Changelog (#7497)

* Update mattermost-server-releases.md

* Update download-latest-tarball.rst

* Update deprecated-features.rst

* Update mattermost-server-releases.md

* Update release-policy.md

* Update mattermost-mobile-releases.md

* Update mattermost-desktop-releases.md

* Update mattermost-v10-changelog.md

* Update mattermost-v9-changelog.md

* Update version-archive.rst

* Update important-upgrade-notes.rst

* Update prepare-to-upgrade-mattermost.rst

* Update open-source-components.rst

* Update mattermost-v10-changelog.md

* Update important-upgrade-notes.rst

* Update deprecated-features.rst

* Update mattermost-server-releases.md

* Update release-policy.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Apply suggestions from code review

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* Update source/about/mattermost-v10-changelog.md

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* Apply suggestions from code review

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* Update source/about/mattermost-v10-changelog.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update source/about/mattermost-v10-changelog.md

Co-authored-by: Christopher Poile <cpoile@gmail.com>

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

---------

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Christopher Poile <cpoile@gmail.com>

* Added guidance on using team-URL over display name (#7588)

* Replaced YES with standard green checkmarks (#7589)

* Docs listening: Elevate comply and secure topics to align with scale (#7592)

* Elevated secure & comply to align with scale

* Added breadcrumb links to related topics

* Clarified that admins can perform any actions on a system (#7596)

* Fixed build warning

* Connected workspaces rewrites & updates for Beta release (#7575)

* Connected workspaces rewrites & updates for Beta release

* Added config settings, page redirects

* Update source/conf.py

* Update source/configure/reporting-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Update source/configure/reporting-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Update source/configure/site-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Update source/configure/site-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Update source/onboard/connected-workspaces.rst

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Update source/configure/site-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Added telemetry and deprecated remote cluster config

* Updated default value

---------

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* Link check fixes

* Added best practice recommendations re: attributes & identifiers (#7562)

---------

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Christopher Poile <cpoile@gmail.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v10.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cwarnermm @amyblais @devinbinnie