Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notification banner and global nav #1292

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Update notification banner and global nav #1292

merged 2 commits into from
Sep 25, 2023

Conversation

emdecr
Copy link
Contributor

@emdecr emdecr commented Sep 15, 2023

Summary

This PR adds the 9.0 announce blog to the notification banner, and updates the global nav to align with mm.com.

@cwarnermm – Feel free to adjust the footer links and I'll mirror the changes on mm.com. Will add more reviewers once we're zipped up.

Thank you!

@emdecr emdecr added 2: Editor Review Requires review by an editor Work in Progress Not yet ready for review labels Sep 15, 2023
@emdecr emdecr requested a review from cwarnermm September 15, 2023 12:41
@emdecr emdecr self-assigned this Sep 15, 2023
@github-actions
Copy link

Newest code from emdecr has been published to preview environment for Git SHA 818822e

3 similar comments
@github-actions
Copy link

Newest code from emdecr has been published to preview environment for Git SHA 818822e

@github-actions
Copy link

Newest code from emdecr has been published to preview environment for Git SHA 818822e

@github-actions
Copy link

Newest code from emdecr has been published to preview environment for Git SHA 818822e

@cwarnermm
Copy link
Member

@emdecr - Let's apply the 2 header updates proposed via x:

  • Let's update the Academy link to point to: https://academy.mattermost.com/
  • Let's update the Release Notes link to: https://docs.mattermost.com/guides/changelogs.html

And just to confirm, the dev docs site footer is far simpler than the docs footer intentionally?

@github-actions
Copy link

Newest code from emdecr has been published to preview environment for Git SHA fa09137

@emdecr
Copy link
Contributor Author

emdecr commented Sep 15, 2023

@cwarnermm Yep – I don't think there's ever been a footer mirror (of docs/mm.com) on this site since I've been here.

@emdecr emdecr removed the Work in Progress Not yet ready for review label Sep 15, 2023
@emdecr emdecr requested a review from nat-gunner September 15, 2023 14:33
@emdecr
Copy link
Contributor Author

emdecr commented Sep 15, 2023

@nat-gunner For review - nav changes for 9.0 - TY!

@cwarnermm
Copy link
Member

@emdecr - phew! For a moment I thought I was mis-remembering one! :)

nat-gunner
nat-gunner approved these changes Sep 15, 2023
View reviewed changes
Copy link

@nat-gunner nat-gunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@emdecr emdecr mentioned this pull request Sep 18, 2023
Merged
cwarnermm
cwarnermm approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @emdecr!!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Sep 25, 2023
@cwarnermm cwarnermm merged commit dd23bd2 into master Sep 25, 2023
2 checks passed
@cwarnermm cwarnermm deleted the header-update-9-0 branch September 25, 2023 14:42
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA fa09137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@nat-gunner nat-gunner nat-gunner approved these changes

Assignees

@emdecr emdecr

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emdecr @cwarnermm @nat-gunner