Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Arch developer setup instructions #1404

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Update Arch developer setup instructions #1404

merged 4 commits into from
Nov 15, 2024

Conversation

sparr
Copy link
Contributor

@sparr sparr commented Oct 3, 2024

Summary

Correct some commands and add more optional steps for setting up the developer environment on Arch Linux (and forks)

@mattermost-build
Copy link
Contributor

Hello @sparr,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 3, 2024
@cwarnermm cwarnermm self-requested a review October 3, 2024 13:03
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Oct 3, 2024
@toninis toninis removed the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 3, 2024
@toninis toninis added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Newest code from sparr has been published to preview environment for Git SHA 3435f06

@sparr
Copy link
Contributor Author

sparr commented Oct 4, 2024

I am not sure how to get from the preview environment link to the page that shows this content which is https://developers.mattermost.com/contribute/more-info/desktop/developer-setup/ on the live site

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm cwarnermm requested review from a team and marianunez and removed request for a team November 15, 2024 13:31
@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 15, 2024
@github-actions GitHub Actions
Copy link

Newest code from sparr has been published to preview environment for Git SHA 147a0dc

@cwarnermm
Copy link
Member

Hi @sparr - To review your changes in the generated preview, use the file path of the page you modified as a guide: /contribute/more-info/desktop/developer-setup/arch.md > Contribute > More Info > Desktop app > Developer Setup > Arch tab.

@sparr
Copy link
Contributor Author

sparr commented Nov 15, 2024

Thank you. The page in the preview environment looks how I expect.

@marianunez marianunez requested review from devinbinnie and removed request for marianunez November 15, 2024 14:51
devinbinnie
devinbinnie approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sparr!

cwarnermm
cwarnermm approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sparr!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 15, 2024
@cwarnermm cwarnermm merged commit e9053b5 into mattermost:master Nov 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sparr @mattermost-build @cwarnermm @devinbinnie @toninis