Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package manager name for RHEL developer-setup #1413

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

jonathan-dove
Copy link
Contributor

Summary

Incorrect package manager was referenced as apt in the RHEL developer documentation. Simple change of apt to yum. Utilized yum instead of dnf as most distributions support either or but not all RHEL variants support dnf if someone was to utilize a EL7 variant.

@mattermost-build
Copy link
Contributor

Hello @jonathan-dove,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei hanzei added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Nov 7, 2024
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jonathan-dove!

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jonathan-dove!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Nov 7, 2024
@cwarnermm cwarnermm merged commit 0414526 into mattermost:master Nov 7, 2024
4 checks passed
@jonathan-dove jonathan-dove deleted the patch-1 branch November 7, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants