Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moussetc/mattermost-plugin-dice-roller to Marketplace #122

Closed
14 tasks done
moussetc opened this issue Sep 26, 2020 · 3 comments
Closed
14 tasks done

Add moussetc/mattermost-plugin-dice-roller to Marketplace #122

moussetc opened this issue Sep 26, 2020 · 3 comments
Assignees
Labels
Plugin/New Request to add a new plugin to the Marketplace

Comments

@moussetc
Copy link

moussetc commented Sep 26, 2020

Summary

Review commit

moussetc/mattermost-plugin-dice-roller@fa92644

Checklist

Product requirements

  • The plugin is published under an Apache v2 compatible license (e.g. no GPL, APGL). A list of compatible licenses can be found here.
  • The source code is available in a public git repository.
  • There is a public issue or bug tracker for the plugin, which is linked in the plugin documentation and linked via support_url in the manifest.
  • The plugin provides detailed usage documentation with at least one screenshot of the plugin in action, list of features, and a development guide. This is typically a README file or a landing page on the web. The link to the documentation is set as homepage_url in the manifest. A great example is the README of the GitHub plugin.
  • For the current release and upcoming ones a changelog has to be published, with a link recorded in the release_notes_url property of the plugin.json manifest.
  • The plugin has to be out of Beta and be released with at least v1.0.0.
  • All configuration is accessible via the Mattermost UI.
  • The plugin ID defined in the manifest must not collide with the ID of an existing plugin in the Marketplace. It should follow the documentation's suggested naming convention.

Technical requirements

  • The plugin works for 60k concurrent connections and in a high-availability deployment. Note: There are currently no publicly-available tools to verify these properties. As such, they are checked during code review by a developer.
  • The plugin logs important events on appropriate log levels to allow System Admins to troubleshoot issues.

Security requirements

  • Security reviews do not reveal any exploitable vulnerabilities in the plugin.
  • The plugin provides an email address or a username on the Community Server used to report vulnerabilities in the future. Please post it into this issue or send it to ben.schumacher@mattermost.com.

Functional requirements

  • The plugin must set a min_server_version in the manifest.
  • The plugin must work on all Mattermost versions greater than or equal to the min_server_version.
@moussetc moussetc added the Plugin/New Request to add a new plugin to the Marketplace label Sep 26, 2020
@hanzei
Copy link
Collaborator

hanzei commented Sep 26, 2020

Awesome, thanks for submitting yet another plugin to the Marketplace @moussetc 🎉

I did a brief review of the code and it looks good 👍

This would be a great plugin to have Slash Command Autocomplete. You can find an example on how to implement this mattermost/mattermost-plugin-gitlab#182. Of cause, that is not blocking for the Marketplace.

@hanzei
Copy link
Collaborator

hanzei commented Sep 26, 2020

The checklist below will be used to track the process of getting your plugin to the Marketplace. It's sole purpose it visibility.

Process checklist

  • Create a private fork under the Mattermost organization; master should only contain a README.md.
  • Give submitter read access to the fork.
  • Create PR to merge upstream into master.
  • Request reviews.
  • Cut plugin release.
  • Add release to Marketplace.
  • Reach out on Marketing Channel to tweet about the plugin.
  • Work with @hanna.park regarding swag.

@hanzei
Copy link
Collaborator

hanzei commented Mar 30, 2021

It's out! Thanks again @moussetc 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugin/New Request to add a new plugin to the Marketplace
Projects
None yet
Development

No branches or pull requests

2 participants