Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v3.1.1 of mattermost-plugin-dice-roller to the Marketplace #175

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Add v3.1.1 of mattermost-plugin-dice-roller to the Marketplace #175

merged 4 commits into from
Mar 30, 2021

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Mar 11, 2021 •
edited
Loading

Summary

Screenshot from 2021-03-11 13-53-55

Ticket Link

Fixes #122

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 11, 2021
iomodo
iomodo previously approved these changes Mar 16, 2021
View reviewed changes
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Mar 16, 2021
DHaussermann
DHaussermann previously approved these changes Mar 25, 2021
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Plugin displays in marketplace as expected
  • Community label is shown
  • New icon displays as expected and looks good on dark theme
  • Tested install and enable
  • Version shows as 3.1.1

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 25, 2021
@hanzei hanzei requested a review from iomodo March 25, 2021 21:06
jespino
jespino reviewed Mar 30, 2021
View reviewed changes
plugins.json Show resolved Hide resolved
agnivade
agnivade reviewed Mar 30, 2021
View reviewed changes
plugins.json Show resolved Hide resolved
plugins.json Show resolved Hide resolved
@hanzei hanzei requested a review from agnivade March 30, 2021 07:14
@hanzei hanzei merged commit 272ee18 into production Mar 30, 2021
@hanzei hanzei deleted the add_mattermost-plugin-dice-roller_v3.1.1 branch March 30, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@agnivade agnivade agnivade approved these changes

@iomodo iomodo Awaiting requested review from iomodo

@DHaussermann DHaussermann Awaiting requested review from DHaussermann

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanzei @jespino @agnivade @iomodo @DHaussermann