Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-59520] Update server model #453

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[MM-59520] Update server model #453

merged 3 commits into from
Sep 16, 2024

Conversation

streamer45
Copy link
Contributor

Summary

I am bumping the model package in preparation for publishing Calls v1.0.0 as we made some additions to the plugin schema that will be needed.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Aug 15, 2024
@streamer45 streamer45 self-assigned this Aug 15, 2024
lieut-data
lieut-data previously approved these changes Aug 16, 2024
View reviewed changes
@streamer45 streamer45 mentioned this pull request Aug 26, 2024
Merged
cpoile
cpoile previously approved these changes Sep 5, 2024
View reviewed changes
@cpoile cpoile added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 5, 2024
@streamer45 streamer45 added the Do Not Merge Should not be merged until this label is removed label Sep 5, 2024
@streamer45 streamer45 dismissed stale reviews from cpoile and lieut-data via 272a680 September 16, 2024 14:57
@streamer45 streamer45 added 2: Dev Review Requires review by a core committer and removed Do Not Merge Should not be merged until this label is removed 4: Reviews Complete All reviewers have approved the pull request labels Sep 16, 2024
@streamer45
Copy link
Contributor Author

Getting this ready to be merged. Needs new approval.

lieut-data
lieut-data previously approved these changes Sep 16, 2024
View reviewed changes
cpoile
cpoile previously approved these changes Sep 16, 2024
View reviewed changes
@streamer45 streamer45 dismissed stale reviews from cpoile and lieut-data via bbd0967 September 16, 2024 15:11
@streamer45
Copy link
Contributor Author

Apologies, but this is the new protocol.

cpoile
cpoile approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more secure this way.

lieut-data
lieut-data approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, but this is the new protocol.

I guess this is marketplace specific?

@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 16, 2024
@streamer45
Copy link
Contributor Author

Apologies, but this is the new protocol.

I guess this is marketplace specific?

@lieut-data I was referring to repository rules which feel a bit strict (borderline painful) when it comes to simple fixes or updates that require re-approval of everyone.

@streamer45 streamer45 merged commit b284582 into production Sep 16, 2024
4 checks passed
@streamer45 streamer45 deleted the MM-59520 branch September 16, 2024 15:24
streamer45 added a commit that referenced this pull request Sep 16, 2024
@streamer45
Revert "Merge pull request #453 from mattermost/MM-59520"
19fa282 
This reverts commit b284582, reversing
changes made to b438a58.
@streamer45 streamer45 mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@cpoile cpoile cpoile approved these changes

Assignees

@streamer45 streamer45

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@streamer45 @lieut-data @cpoile