Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Calls v1.0.1 #455

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Release Calls v1.0.1 #455

merged 1 commit into from
Sep 16, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Releasing v1 on Marketplace. This is what's pre-packaged in MM v10.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Sep 16, 2024
@streamer45 streamer45 self-assigned this Sep 16, 2024
lieut-data
lieut-data approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but I wonder if we should have merged master into production separately?

@streamer45
Copy link
Contributor Author

@lieut-data I admit we've been defaulting to production for a long time. I don't think Calls was ever ported to master.

@cpoile cpoile added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 16, 2024
@lieut-data
Copy link
Member

@lieut-data I admit we've been defaulting to production for a long time. I don't think Calls was ever ported to master.

Ah, maybe someone has updated production without regenerating plugin.json -- hence the noisy diffs. It's probably fine :p

@streamer45 streamer45 merged commit b5e1f05 into production Sep 16, 2024
4 checks passed
@streamer45 streamer45 deleted the calls-v1.0.1 branch September 16, 2024 17:13
streamer45 added a commit that referenced this pull request Sep 16, 2024
@streamer45
Revert "Merge pull request #455 from mattermost/calls-v1.0.1"
ca92378 
This reverts commit b5e1f05, reversing
changes made to b284582.
@streamer45 streamer45 mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@cpoile cpoile cpoile approved these changes

Assignees

@streamer45 streamer45

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@streamer45 @lieut-data @cpoile