Fix typo: use correct base branch in PR creation #7720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoinixgrr
approved these changes
Dec 15, 2023
cpoile
pushed a commit
that referenced
this pull request
Dec 21, 2023
fewva
pushed a commit
to fewva/mattermost-mobile
that referenced
this pull request
Jan 12, 2024
cyrusjc
pushed a commit
to cyrusjc/mattermost-mobile
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The version bump script works, but contains a typo at PR creation time: it should try to merge the new branch against
BRANCH_TO_BUILD, but instead always creates the PR againstmain. E.g.: #7719This PR fixes that, so that we're able to fully control which branch to bump the build/version numbers for.
Ticket Link
https://mattermost.atlassian.net/browse/CLD-6707
Release Note