-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cannot read data when opening a deeplink #8109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only one extra test case I thought could be useful, but not a blocker.
Requesting review from Lindy for she was able to repro the issue - mattermost/mattermost#26803 (comment) For the failed Detox (on build), it's not related here and was happening even from main. Will investigate separately - https://community.mattermost.com/core/pl/t1zi5wwic3fdidzeh51z67gybc |
/update-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enahum - I have tested according to repro steps and I am taken to the account creation page in a browser. Creating an account works without issue and I can log into MM mobile browser
Summary
The initial error was caused by the launch parsing of deep links where the deeplink did not match the patterns for channel or permalink, so in this PR apart of fixing the issue when the deep link is invalid we also handle a deeplink for a server that we do not have registered yet by presenting the server screen an populating with the url of the deep link
Ticket Link
https://mattermost.atlassian.net/browse/MM-58467
Checklist
Release Note