-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mitmproxy + low bandwidth + automated QA using detox #8202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes Rahim, lgtm overall! I have left a few comments with some suggestions.
Also I was looking up to check if the throttling could be done directly with mitmproxy, instead of changing the host network config, and found your comment in the related issue, which was awesome 😄 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rahim, the only needed change to avoid a confusing users would be around adding the label name to the concurrency group, please check this comment
@mvitale1989 done! Thanks so much for all your suggestions and feedback! |
Summary
Update E2E iOS Detox Test to have the ability to run in a low-bandwidth environment using similar label on PR. A new label has been introduced called
E2E iOS tests for PR (LBW 1)
. The idea is to be able to create multiple profile (LBW 1-n) and change the bandwidth speed + ping time.Ticket Link
https://mattermost.atlassian.net/browse/MM-60378
TODOs
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on:
iPhone 14, iOS 17.4 (even though was was passed is iOS 17.0)
Screenshots
Release Note