Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for xCode 16 changes #8254

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add fixes for xCode 16 changes #8254

merged 1 commit into from
Oct 11, 2024

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Oct 11, 2024

Summary

With XCode 16 some changes were needed to properly compile the app.

This PR addresses those changes.

Ticket Link

NONE

Release Note

NONE

@larkox larkox added the 2: Dev Review Requires review by a core commiter label Oct 11, 2024
@larkox larkox mentioned this pull request Oct 11, 2024
@chrisfromredfin
Copy link

Oof, can confirm that after days of trying to build these should do it (finally built about 12 hours ago - seeing this issue is 2 hours old 🤣)

For reference, the way I fixed it was while the npm run build:ios was running, but after the pods installed, I ran the following three commands from the mattermost-mobile directory.

These were the more base-level patches that were needed but are encapsulated by the typealias and the bump of @sentry/react-native packages that appear in this MR.

sed -i '' '41i\
#include <sys/_types/_ucontext64.h>
' ios/Pods/Sentry/Sources/SentryCrash/Recording/Tools/SentryCrashMachineContext.c

find ios/Gekidou/Sources/Gekidou/Storage/ -name "*.swift" -exec sed -i '' 's/= Expression/= SQLite.Expression/g' {} +

find ios/Gekidou/Sources/Gekidou/Storage/ -name "*.swift" -exec sed -i '' 's/user.get(Expression</user.get(SQLite.Expression</g' {} +

Note the sed syntax is BSD-style, since, ya know, Mac.

@larkox larkox added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 11, 2024
@larkox larkox merged commit 94a7231 into main Oct 11, 2024
28 checks passed
@larkox larkox deleted the xcode16Fixes branch October 11, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants