Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calls-common #8255

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Update calls-common #8255

merged 2 commits into from
Oct 11, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Updating calls-common to latest and the rtcMonitorInterval value to match the plugin's side. Increasing the interval helps to lower the variance on gathered stats.

Release Note

NONE

@streamer45 streamer45 added the 2: Dev Review Requires review by a core commiter label Oct 11, 2024
@streamer45 streamer45 self-assigned this Oct 11, 2024
@streamer45
Copy link
Contributor Author

@amyblais I'd like to get this into 2.22 if possible since it goes with #8246

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 11, 2024
@amyblais amyblais added this to the v2.22.0 milestone Oct 11, 2024
@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 11, 2024
@streamer45 streamer45 merged commit fa7e7ef into main Oct 11, 2024
36 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@streamer45 streamer45 deleted the MM-60561 branch October 11, 2024 19:47
mattermost-build pushed a commit that referenced this pull request Oct 11, 2024
@streamer45 @mattermost-build
Update calls-common (#8255)
589afdc 
* Bump rtc monitor interval to 10s

* Update calls-common

(cherry picked from commit fa7e7ef)
@mattermost-build mattermost-build mentioned this pull request Oct 11, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 11, 2024
streamer45 added a commit that referenced this pull request Oct 11, 2024
@mattermost-build @streamer45
Update calls-common (#8255) (#8257)
d982efa 
* Bump rtc monitor interval to 10s

* Update calls-common

(cherry picked from commit fa7e7ef)

Co-authored-by: Claudio Costa <cstcld91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahimrahman rahimrahman rahimrahman approved these changes

@cpoile cpoile cpoile approved these changes

@enahum enahum Awaiting requested review from enahum

Assignees

@streamer45 streamer45

Labels
4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@streamer45 @mattermost-build @cpoile @rahimrahman @amyblais @mm-cloud-bot