Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (MM-59973) emoji count 0 update #8256

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix: (MM-59973) emoji count 0 update #8256

merged 4 commits into from
Oct 15, 2024

Commits on Oct 11, 2024

  1. reversed from all useMemo to useMemo + useEffect 

    * tried to include everything into useMemo was an anti-pattern
* moved back to useMemo + useEffect
* previousNumber and animateToNumber comparison has some flaw when dealing with difference length between the two
    @rahimrahman
    rahimrahman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6d4609d View commit details
    Browse the repository at this point in the history

  2. simple fix

    @rahimrahman
    rahimrahman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a6cd274 View commit details
    Browse the repository at this point in the history

  3. fix more silly mistakes

    @rahimrahman
    rahimrahman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4e8314a View commit details
    Browse the repository at this point in the history

  4. move _previousNumberString to constant

    @rahimrahman
    rahimrahman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a335117 View commit details
    Browse the repository at this point in the history