Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: exhaustive-deps eslint rules from 'off' to 'warn' #8272

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: exhaustive-deps eslint rules from 'off' to 'warn' #8272

merged 1 commit into from
Oct 21, 2024

Conversation

rahimrahman
Copy link
Contributor

Summary

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

@mm-cloud-bot mm-cloud-bot added kind/chore Categorizes issue or PR as related to updates that are not production code. release-note labels Oct 18, 2024
@rahimrahman
Copy link
Contributor Author

@larkox && @enahum -- this shouldn't cause any issue even with ci (I guess we'll see), but I'm hoping this is not a problem for you two, either?

Rajat-Dabade
Rajat-Dabade approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@rahimrahman
Copy link
Contributor Author

No QA necessary as this change is really for developers experience.

@rahimrahman rahimrahman merged commit 9338a1c into main Oct 21, 2024
20 checks passed
@rahimrahman rahimrahman deleted the chore/exhaustive-deps-warn branch October 21, 2024 15:06
@amyblais amyblais added this to the v2.23.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@enahum enahum enahum approved these changes

@larkox larkox larkox approved these changes

@sbishel sbishel Awaiting requested review from sbishel

Assignees
No one assigned
Labels
kind/chore Categorizes issue or PR as related to updates that are not production code. release-note
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rahimrahman @larkox @enahum @Rajat-Dabade @amyblais @mm-cloud-bot