Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-59449 Add tests for actions/remote/post #8301

Merged
merged 6 commits into from
Nov 4, 2024
Merged

MM-59449 Add tests for actions/remote/post #8301

merged 6 commits into from
Nov 4, 2024

Conversation

jwilander
Copy link
Member

@jwilander jwilander commented Oct 30, 2024 •
edited
Loading

Summary

Add unit tests for actions/remote/post. Coverage increases from 15% to 95.86%.

Ticket Link

https://mattermost.atlassian.net/browse/MM-59449

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: n/a

Screenshots

n/a

Release Note

NONE

@jwilander jwilander added the 2: Dev Review Requires review by a core commiter label Oct 30, 2024
yasserfaraazkhan
yasserfaraazkhan approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rahimrahman rahimrahman requested review from a team and M-ZubairAhmed and removed request for a team October 31, 2024 13:51
enahum
enahum approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as long as the suggestion is applied ;)

app/actions/remote/post.ts Outdated Show resolved Hide resolved
@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 4, 2024
@jwilander jwilander merged commit 3764bf0 into main Nov 4, 2024
12 checks passed
@jwilander jwilander deleted the mm-59449_actions-remote-post-tests branch November 4, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@enahum enahum enahum approved these changes

@M-ZubairAhmed M-ZubairAhmed Awaiting requested review from M-ZubairAhmed M-ZubairAhmed was automatically assigned from mattermost/core-reviewers

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwilander @enahum @yasserfaraazkhan @mm-cloud-bot