Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A couple of things were fixed here, first instead of using the window frame we are using the window bounds and secondly we only consider it to be a tablet layout if the app takes at least 2/3 of the screen width.
bounds vs. frame
bounds
: Represents the window’s coordinate system and its size within its own context. The origin is typically (0,0), with width and height that represent the actual size of the window's content area.frame
: Represents the window’s rectangle relative to its parent coordinate system, typically the screen’s coordinate space. If the window is rotated or scaled, the frame will change to reflect its position and orientation relative to the screen.Using bounds is generally more reliable for checking size because:
Ticket Link
https://mattermost.atlassian.net/browse/MM-61317
Device Information
This PR was tested on: iPad
Release Note