[CLD-8507] Upgrade Go version, controller-runtime dependency #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er updates to accompany
|
@nickmisasi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
nickmisasi
changed the title
mm-cloud-bot
added
release-note-none
nickmisasi
commented
Nov 1, 2024
Comment on lines
+83
to
+84
| TEMP_DIR=$(mktemp -d) | ||
| trap 'rm -rf "${TEMP_DIR}"' EXIT |
There was a problem hiding this comment.
--output-dir became a required param with the upgraded version - this just creates a temporary dir that's later deleted to use for that arg.
gabrieljackson
approved these changes
Nov 4, 2024
.github/workflows/ci.yml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: ci/setup-go | |||
| uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0 | |||
| uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v3.5.0 | |||
There was a problem hiding this comment.
Can we get this version number updated to avoid possible future confusion? Same thing for the one below.
fmartingr
approved these changes
Nov 5, 2024
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
nickmisasi
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates controller-runtime dependency to latest. This requires a Go version upgrade. The Go version upgrade required a few other package upgrades.
The controller-runtime upgrade resulted in some changes to the way the fake client handles status updates - see kubernetes-sigs/controller-runtime#2259 - adjusted tests accordingly so they'd pass.
Ticket Link
https://mattermost.atlassian.net/browse/CLD-8507
Release Note