Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook creation could show non-clickable version of the link #196

Closed
DHaussermann opened this issue Aug 12, 2020 · 1 comment · Fixed by #199
Closed

Webhook creation could show non-clickable version of the link #196

DHaussermann opened this issue Aug 12, 2020 · 1 comment · Fixed by #199
Assignees
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Milestone

Comments

@DHaussermann
Copy link

When you create a webhook via slash command, the address that GitLab uses for the webhook is shown in the confirmation post. This is displayed as a clickable link which may be a bit confusing for people. Even though the link is correct, attempting to follow it will result in a 401 response and the text not authorized .

It may make more sense to show the link as a commented line of text https://dkh-local.ngrok.io/plugins/com.github.manland.mattermost-plugin-gitlab/webhook rather than the clickable link https://dkh-local.ngrok.io/plugins/com.github.manland.mattermost-plugin-gitlab/webhook

Steps:

  • Subscribe to a project
  • Using the slash command, add a webhook to deliver the evsent

Observed:
A. Confirmation post shows a list of events and a clickable link such as https://dkh-local.ngrok.io/plugins/com.github.manland.mattermost-plugin-gitlab/webhook
B. Clicking the link results in 401

@DHaussermann DHaussermann added Triage Type/Enhancement New feature or improvement of existing feature labels Aug 12, 2020
@hanzei hanzei modified the milestones: v1.2.0, v1.3.0 Aug 13, 2020
@hanzei hanzei added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Triage labels Aug 13, 2020
@kosgrz
Copy link
Contributor

kosgrz commented Aug 17, 2020

I will do it :)

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
3 participants