Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.0 #191

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Bump version to 1.2.0 #191

merged 1 commit into from
Aug 24, 2020

Conversation

iomodo
Copy link
Contributor

@iomodo iomodo commented Jul 29, 2020

Summary

Bump version to v1.2.0

Proposal to bump Minor Version to prep for release with the following Release Notes:

Enhancements

331ba44 Add more manifest data (#133)
43a23dc Add a "web hook needed" reminder (#134)
e5d1e89 Manage web hooks with slash commands(#137)
3644757 Add autocomplete for gitlab slash command (#182)

Fixes

1353595 Use siteurl on webapp to avoid issues with subpath (#177)
c5821e3 Update dependencies (#190)

Ticket Link

#170

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   40.84%   40.84%           
=======================================
  Files          16       16           
  Lines        1714     1714           
=======================================
  Hits          700      700           
  Misses        944      944           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5821e3...f033bee. Read the comment docs.

@iomodo iomodo added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 29, 2020
@iomodo iomodo added this to the v1.2.0 milestone Jul 29, 2020
@hanzei hanzei linked an issue Jul 29, 2020 that may be closed by this pull request
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jul 29, 2020
@andrewgdunn
Copy link

Possible to release? The webhooks feature is quite appealing!

Copy link

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Webhook feature is awesome.

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Aug 10, 2020
@DHaussermann
Copy link

End to end testing done.

  • Reviewed PRs since last version bump and ensured release tests were current
  • Ran through usual end to end tests including new features
  • Confirmed version correctly shown as 1.2.0

Release testing found a pre-existing bug #194 and also this issue here #196 related to webhook creation. Unless I'm misunderstanding, this seems like just a slightly confusing ux with no functional impact.

@hanzei or @iomodo, unless #196 has some broader impact I'm not realizing. I'd say we're fine to cut the release. Please confirm.

@hanzei
Copy link
Collaborator

hanzei commented Aug 13, 2020

Thanks for the review @DHaussermann 👍

#196 only has minor impact. I think it's fine to ship the release.

I've also converted all found issues into HW.

@hanzei hanzei removed a link to an issue Aug 13, 2020
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed. Testing summary above.
LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 13, 2020
@iomodo iomodo merged commit 34adde9 into master Aug 24, 2020
@iomodo iomodo deleted the bump-version-v1.2.0 branch August 24, 2020 12:57
@hanzei hanzei added the Docs/Not Needed Does not require documentation label Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants