-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.2.0 #191
Conversation
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 40.84% 40.84%
=======================================
Files 16 16
Lines 1714 1714
=======================================
Hits 700 700
Misses 944 944
Partials 70 70 Continue to review full report at Codecov.
|
Possible to release? The webhooks feature is quite appealing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Webhook feature is awesome.
End to end testing done.
Release testing found a pre-existing bug #194 and also this issue here #196 related to webhook creation. Unless I'm misunderstanding, this seems like just a slightly confusing ux with no functional impact. @hanzei or @iomodo, unless #196 has some broader impact I'm not realizing. I'd say we're fine to cut the release. Please confirm. |
Thanks for the review @DHaussermann 👍 #196 only has minor impact. I think it's fine to ship the release. I've also converted all found issues into HW. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed. Testing summary above.
LGTM!
Summary
Bump version to v1.2.0
Proposal to bump Minor Version to prep for release with the following Release Notes:
Enhancements
331ba44 Add more manifest data (#133)
43a23dc Add a "web hook needed" reminder (#134)
e5d1e89 Manage web hooks with slash commands(#137)
3644757 Add autocomplete for gitlab slash command (#182)
Fixes
1353595 Use siteurl on webapp to avoid issues with subpath (#177)
c5821e3 Update dependencies (#190)
Ticket Link
#170