Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook add fails on sub-groups #200

Closed
andrewgdunn opened this issue Aug 26, 2020 · 2 comments · Fixed by #202
Closed

webhook add fails on sub-groups #200

andrewgdunn opened this issue Aug 26, 2020 · 2 comments · Fixed by #202
Assignees
@ericjaystevens
Labels
Type/Bug Something isn't working
Milestone
v1.3.0

Comments

@andrewgdunn
Copy link

Just consumed 1.2.0, /gitlab webhook add <group/project> seems to work, however it seems to fail on anything involving sub-groups: /gitlab webhook add <group/sub-group/project>.
@hanzei hanzei added the Type/Bug Something isn't working label Aug 28, 2020
@hanzei
Copy link
Collaborator

hanzei commented Aug 28, 2020

@ericjaystevens you are going to work on this, right?

@ericjaystevens
Copy link
Contributor

@hanzei I had to scope out the issue before I committed but yes, I'll take this. It should be a quick fix, no upstream changes required.

ericjaystevens added a commit to ericjaystevens/mattermost-plugin-gitlab that referenced this issue Sep 7, 2020
@ericjaystevens
resolves issue mattermost#200 enables webhook commands on subgroups
4cd1a80
@ericjaystevens ericjaystevens mentioned this issue Sep 7, 2020
Merged
@hanzei hanzei added this to the v1.3.0 milestone Sep 7, 2020
hanzei pushed a commit that referenced this issue Oct 21, 2020
@ericjaystevens
resolves issue #200 enables webhook commands on subgroups (#202)
b16b42b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericjaystevens ericjaystevens

Labels
Type/Bug Something isn't working
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

resolves issue #200 enables webhook commands on subgroups ericjaystevens/mattermost-plugin-gitlab
3 participants
@andrewgdunn @ericjaystevens @hanzei