Sidebar header MR count should show assigned MRs instead of opened MRs

[jdeamicis]

As of now I see that the MR counter in the sidebar (the one showing Your open merge requests) shows the MRs someone has opened (i.e. the MRs for which the user is the author).

I believe it would make more sense to have the assigned MRs (i.e. the ones for which a user is assignee), rather than the opened ones.

Or maybe it could be made configurable.

[mickmister]

Hi @deandrade87, Are you interested in implementing this?

[sibasankarnayak]

@mickmister wanted to check on this, is someone working on this ?

if no wanted to check on the requirement. does this feature seeking to list only PR been assigned to user , instead of listing all the PR opened by user?

[mickmister]

@hanzei Do you have thoughts on this? I would think that "My opened MRs" is what someone would mainly want to know about, but maybe conventions in GitLab are a bit different than GitHub.

It looks like the "assignments" category currently only uses issues and not MRs, so assigned MRs are neglected in the counts in general.

mattermost-plugin-gitlab/server/gitlab/api.go

Lines 281 to 307 in bbd7d38

	func (g *gitlab) GetYourAssignments(user *UserInfo) ([]*internGitlab.Issue, error) {
	client, err := g.gitlabConnect(*user.Token)
	if err != nil {
	return nil, err
	}
	opened := stateOpened
	scope := scopeAll
	var result []*internGitlab.Issue
	var errRequest error
	if g.gitlabGroup == "" {
	result, _, errRequest = client.Issues.ListIssues(&internGitlab.ListIssuesOptions{
	AssigneeID: &user.GitlabUserID,
	State: &opened,
	Scope: &scope,
	})
	} else {
	result, _, errRequest = client.Issues.ListGroupIssues(g.gitlabGroup, &internGitlab.ListGroupIssuesOptions{
	AssigneeID: &user.GitlabUserID,
	State: &opened,
	Scope: &scope,
	})
	}
	return result, errRequest

Maybe we should match the GitHub plugin's behavior and include issues and MRs for the assignments category? @deandrade87 How do you feel about this?

[mickmister]

@sibasankarnayak Is there a reason you're wanting to pick up an issue that's not in the sprint planning board? I ask because there are a decent amount of open tickets in the "Todo" column.

[mickmister]

The user connect welcome message states that the third category contains both merge requests and issues you are assigned to. @dipak-demansol Are you able to verify this is the case?

cc @hanzei

[sibasankarnayak]

@sibasankarnayak Is there a reason you're wanting to pick up an issue that's not in the sprint planning board? I ask because there are a decent amount of open tickets in the "Todo" column.

@mickmister i picked it bymistake , but thought as worked on it so raised the PR

[hanzei]

Maybe we should match the GitHub plugin's behavior and include issues and MRs for the assignments category?

That sound like the optimal solution to me

[jdeamicis]

@hanzei Do you have thoughts on this? I would think that "My opened MRs" is what someone would mainly want to know about, but maybe conventions in GitLab are a bit different than GitHub.

It looks like the "assignments" category currently only uses issues and not MRs, so assigned MRs are neglected in the counts in general.

mattermost-plugin-gitlab/server/gitlab/api.go

Lines 281 to 307 in bbd7d38

	func (g *gitlab) GetYourAssignments(user *UserInfo) ([]*internGitlab.Issue, error) {
	client, err := g.gitlabConnect(*user.Token)
	if err != nil {
	return nil, err
	}
	opened := stateOpened
	scope := scopeAll
	var result []*internGitlab.Issue
	var errRequest error
	if g.gitlabGroup == "" {
	result, _, errRequest = client.Issues.ListIssues(&internGitlab.ListIssuesOptions{
	AssigneeID: &user.GitlabUserID,
	State: &opened,
	Scope: &scope,
	})
	} else {
	result, _, errRequest = client.Issues.ListGroupIssues(g.gitlabGroup, &internGitlab.ListGroupIssuesOptions{
	AssigneeID: &user.GitlabUserID,
	State: &opened,
	Scope: &scope,
	})
	}
	return result, errRequest

Maybe we should match the GitHub plugin's behavior and include issues and MRs for the assignments category? @deandrade87 How do you feel about this?

So, on GitLab the main buttons where a user sees their tasks are:

• issues assigned to the user (this is compatible with what the mattermost plugin does already)
• Merge Requests assigned to the user or waiting for a review by the user
• ToDos (which are usually generated whenever a user is mentioned or so). I believe the mattermost plugin is treating these correctly.

So, for the second category I would expect the same behaviour as GitLab's, namely MRs assigned + pending review, NOT the MRs opened by a user.

Maybe we should match the GitHub plugin's behavior and include issues and MRs for the assignments category?

That sound like the optimal solution to me

I would tend to disagree. Mattermost users most likely expect to see on the plugin the exact same numbers they see in their GitHub or GitLab systems. Therefore I would expect the two plugins for GitHab and GitLab to have different behaviours, depending on what the underlying systems do.

[catalintomai]

Triage agreed that @deandrade87 's suggestion is valid.

[wiersgallak]

Closing due to inactivity. The issue can be reopened with more interest from our community.

[mickmister]

@mkdbns I've added this to the plugin maintenance board. This isn't particularly urgent, but has been brought up by a few customers recently https://community.mattermost.com/core/pl/9pdx4qfbob8d7rs6jbs8ffaooo. The task is to implement the LHS counters as they are shown in GitLab's UI, as described here #271 (comment)

[raghavaggarwal2308]

@mickmister I have gone through the discussion and I think it would be best to have four buttons here (As there are three buttons on Gitlab and the "Merge requests" button has two subparts):

1. Merge Request Assigned: This will display all the PRs assigned to the user.
2. Merge Requests Needing Review: This will display the PRs assigned to the user for review.
3. Issues: This will display all the issues assigned to a user (Same as the Gitlab system). This is already implemented but currently, the name of this button is "Your Assignments", we will update it to "Issues".
4. To-Do List: Will display all the To-Dos (Same as the Gitlab system). This is already implemented but currently, the name of this button is "Unread Messages", we will update it to "To-Do list".

We are also thinking to update the icons on the "Issues" and "To-Do List" buttons to match the icons on Gitlab.
Please let us know your opinions on this.

Buttons on Gitlab:

Demo video with the updated names on buttons:
Demo-video

[mickmister]

@raghavaggarwal2308 Awesome, this all LGTM 👍

[mickmister]

@jdeamicis Do you agree with this direction?