Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpath server is missing GitLab icons on Upgrade #343

Closed
Tracked by #337
DHaussermann opened this issue Dec 8, 2022 · 8 comments · Fixed by #347
Closed
Tracked by #337

Subpath server is missing GitLab icons on Upgrade #343

DHaussermann opened this issue Dec 8, 2022 · 8 comments · Fixed by #347
Assignees
Labels
Type/Bug Something isn't working
Milestone

Comments

@DHaussermann
Copy link

I see an issue on the subpath server where the GitLab icon is missing after the upgrade.
image

0/5 this may be a subpath specific issue. I've not see it on other servers only here https://subpath.test.mattermost.com/mattermost
image
0/5 This 2nd screen seems to show it's trying to fetch from a relative path and failing.

@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Dec 8, 2022
@lieut-data lieut-data self-assigned this Dec 12, 2022
lieut-data added a commit that referenced this issue Dec 12, 2022
This ensures the icon can be correctly loaded when a subpath is configured and the application isn't running at the root.

Fixes: #343
@hanzei hanzei added this to the v1.6.0 milestone Dec 12, 2022
@hanzei hanzei removed the Triage label Dec 12, 2022
@DHaussermann
Copy link
Author

DHaussermann commented Dec 13, 2022

@lieut-data strangely - I see no change when I deploy this to the sub path server
image

The commit I am building an uploading is correct
image

I have also tried an incognito session with fresh cache and see no change. Maybe I'm missing something here you could suggest I check to isolate what's happening.

@lieut-data
Copy link
Member

@DHaussermann, can you share the link to that subpath instance? From the screenshot, it looks like Playbooks is affected as well (but not Boards), so I'd like to understand where the issue is potentially across multiple products.

@DHaussermann
Copy link
Author

@lieut-data there is an invite link here https://subpath.test.mattermost.com/mattermost/signup_user_complete/?id=hzzfk8adk7by3ptwmxatu5ogpc&sbr=sa

Please ping me if you need an account promoted.

@lieut-data
Copy link
Member

Thanks, @DHaussermann! Do you recall what I need to do as a user to get the apps bar enabled?
image

@DHaussermann
Copy link
Author

DHaussermann commented Dec 14, 2022

@lieut-data I have enabled it for you here
image

Note that the config may roll back to know state nightly on some of these test servers.

Let me know if you have any issue uploading or enabling the plugin via the sys console (Or if you want me to re-upload the build from this brach I compiled locally)

@lieut-data
Copy link
Member

Aha, thanks! Yeah, if not already installed, it would be great to have my credentials boosted to sysadmin so I can iterate here. Thanks, @DHaussermann!

@DHaussermann
Copy link
Author

DHaussermann commented Dec 14, 2022

@lieut-data the server restores it config nightly so, I have now re-enabled and configured the plugin so authentication will work.

I also promoted your user I found
@jesse
Email: jesse@mattermost.com

@lieut-data
Copy link
Member

@DHaussermann, after digging into this for a bit, it seems that /public handling for plugins is broken altogether with subpaths. Fix at the server now up at mattermost/mattermost#21886.

@hanzei hanzei mentioned this issue Jan 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants