Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting and wording improvements #179

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Formatting and wording improvements #179

merged 1 commit into from
Jul 25, 2020

Conversation

bbodenmiller
Copy link
Contributor

Summary

Ticket Link

@codecov
Copy link

codecov bot commented Jun 11, 2020 •
edited
Loading

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   42.31%   42.31%           
=======================================
  Files          16       16           
  Lines        1633     1633           
=======================================
  Hits          691      691           
  Misses        871      871           
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d1e89...12b1d75. Read the comment docs.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jun 11, 2020
iomodo
iomodo approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @bbodenmiller

@iomodo iomodo added the 1: PM Review Requires review by a product manager label Jun 12, 2020
@iomodo iomodo removed the 2: Dev Review Requires review by a core committer label Jun 12, 2020
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager labels Jul 25, 2020
@hanzei hanzei merged commit 3cfa4df into mattermost:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrothschild aaronrothschild aaronrothschild approved these changes

@iomodo iomodo iomodo approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbodenmiller @aaronrothschild @iomodo @hanzei