Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log non actionable errors on WARN level #353

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Log non actionable errors on WARN level #353

merged 1 commit into from
Jan 4, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Jan 2, 2023

Summary

Ticket Link

Fixes #352

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jan 2, 2023
@hanzei hanzei added this to the v1.6.0 milestone Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 31.98% // Head: 32.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a55cf68) compared to base (82c55a2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   31.98%   32.00%   +0.01%     
==========================================
  Files          21       21              
  Lines        3392     3390       -2     
==========================================
  Hits         1085     1085              
+ Misses       2198     2196       -2     
  Partials      109      109              
Impacted Files Coverage Δ
server/api.go 23.82% <0.00%> (ø)
server/cluster.go 0.00% <ø> (ø)
server/command.go 23.92% <0.00%> (ø)
server/plugin.go 15.29% <0.00%> (ø)
server/subscriptions.go 47.20% <0.00%> (ø)
server/webhook.go 40.11% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@blue40524 blue40524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server/command.go

@blue40524
Copy link

server/command.go

I approved

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 4, 2023
@hanzei hanzei merged commit 57e74ce into master Jan 4, 2023
@hanzei hanzei deleted the 352_log-error branch January 4, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non actionable error are logged on ERROR level
3 participants