Remove duplicate oauth step #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github plugin PR: mattermost/mattermost-plugin-github#691 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 32.93% 32.94%
=======================================
Files 22 22
Lines 4014 4013 -1
=======================================
Hits 1322 1322
+ Misses 2561 2560 -1
Partials 131 131
☔ View full report in Codecov by Sentry. |
spirosoik
approved these changes
Aug 21, 2023
mickmister
approved these changes
Aug 21, 2023
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes a duplicate step from the oauth setup flow. Please note that this change doesn't impact users - the flow library already ensured that duplicate steps don't get shown.
Ticket Link
None