Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs migration from GitBook > GitHub README #401

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Docs migration from GitBook > GitHub README #401

merged 2 commits into from
Sep 7, 2023

Conversation

cwarnermm
Copy link
Member

No description provided.

@cwarnermm cwarnermm added the 2: Dev Review Requires review by a core committer label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4697cd7) 32.91% compared to head (be17a1b) 32.91%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files          22       22           
  Lines        4017     4017           
=======================================
  Hits         1322     1322           
  Misses       2564     2564           
  Partials      131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spirosoik
spirosoik approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mickmister
mickmister reviewed Sep 7, 2023
View reviewed changes
docs/setup/configuration.md
@@ -1,54 +0,0 @@
## Configuration

### Step 1: Register an OAuth Application in GitLab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this information be relocated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's already in the README

Copy link
Contributor

@mickmister mickmister Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the PR description can describe what's happening here. Something like "This content has already been moved to README. Just cleaning up files no longer being used." Also, there's more going on here than "updating legacy links"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree that my breadcrumb trail isn't ideal. I hadn't fully appreciated all of the changes needed when I started the PR.

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 7, 2023
@cwarnermm cwarnermm changed the title Updated legacy links Docs migration from GitBook > GitHub README Sep 7, 2023
@cwarnermm cwarnermm merged commit 7190bfd into master Sep 7, 2023
9 checks passed
@cwarnermm cwarnermm deleted the updated-legacy-links branch September 7, 2023 16:55
@avas27JTG avas27JTG mentioned this pull request Nov 29, 2023
Merged
@avas27JTG avas27JTG added this to the v1.8.0 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spirosoik spirosoik spirosoik approved these changes

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cwarnermm @spirosoik @mickmister @avas27JTG