Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-383] Fix UX for member_access_request in right hand sidebar #407

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

Screenshots

image

What to test?

  • ToDos of type "member_access_request" are rendered properly in the RHS.
Steps to reproduce:
  1. Connect your Gitlab account.
  2. Generate a notification of type "member_access_request" on the Gitlab side. (You can do so by making an access request to one of your project/group by some another user)
  3. Open the RHS for todos/unreads.
Environment:

MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0

Ticket Link

Fixes #383

* [MI-3567] Fix UX for member_access_request in right hand sidebar

* [MI-3567] Review fixes

* [MI-3567] Added a semicolon

* [MI-3567] Review fixes
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7190bfd) 32.91% compared to head (09ce146) 32.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files          22       22           
  Lines        4017     4017           
=======================================
  Hits         1322     1322           
  Misses       2564     2564           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raghavaggarwal2308
Copy link
Contributor Author

@mickmister Fixed the review comments mentioned by you

@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Oct 10, 2023
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved. LGTM

@mickmister mickmister merged commit a7bba27 into mattermost:master Nov 28, 2023
9 checks passed
@avas27JTG avas27JTG added this to the v1.8.0 milestone Nov 29, 2023
@avas27JTG avas27JTG mentioned this pull request Nov 29, 2023
@avas27JTG avas27JTG modified the milestones: v1.9.0, v1.8.0 Nov 29, 2023
@mickmister mickmister mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX gap when group membership is requested
4 participants